Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a page heading component for an automation with "Explore Events" button #2754

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

pleek91
Copy link
Collaborator

@pleek91 pleek91 commented Sep 24, 2024

Description

Adds a page heading component for an automation. The heading is currently duplicated in both oss and cloud. Adding a single page heading component here and adding the "Explore Events" button as part of closing out PrefectHQ/prefect#15430

@pleek91 pleek91 requested a review from a team as a code owner September 24, 2024 17:21

const filter = computed<PartialWorkspaceEventsFilter>(() => ({
anyResource: {
id: [`prefect-cloud.automation.${props.automation.id}`],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell both cloud and oss use that id.

Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 question, otherwise lgtm

@pleek91 pleek91 merged commit b3b99ca into main Sep 24, 2024
2 checks passed
@pleek91 pleek91 deleted the explore-automation-events branch September 24, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants