Deployment concurrency limits/configurable collision strategy #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if we can make the options more self-explanatory. 🤔 What if the user-facing text for the options was something like "Enqueue new runs" or "Cancel new runs"? |
It's a good question. I considered it but decided to lean on parity with the client-side python implementation to reduce confusion. update: I think we can always update and make this clearer further down the line so i'm gonna go with getting the functionality merged in here and then if we get later feedback, we can always revisit - 🚀 |
collincchoy
deleted the
deployment-concurrency-limits/configurable-collision-strategy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to edit/update a deployment's
deployment.concurrency_options.collision_strategyfrom the UI.