Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment.concurrency_limit always null. #2743

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

collincchoy
Copy link
Contributor

PrefectHQ/prefect#15426 includes some API changes that results in the deployment details always showing the concurrency limit as None.

That PR:

  • adds a full GCL/concurrencylimitv2 onto deployment responses that have a concurrency limit
  • makes the top-level concurrency_limit value always null -- would remove but keeping it for backwards compatibility.

The changes here should be backwards compatible in that it uses concurrency_limit if present else falls back to the nested limit value else null.

@collincchoy collincchoy requested a review from a team as a code owner September 19, 2024 21:40
@collincchoy collincchoy merged commit 8087d90 into main Sep 19, 2024
2 checks passed
@collincchoy collincchoy deleted the read-deployment-concurrency-limit-from-nested-gcl branch September 19, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants