-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update tabs on tiles #1064
update tabs on tiles #1064
Conversation
…support for additional or dynamic tabs in future;
member invitation bug - invite a user on the free tier the first time the modal appears
Remove requirement to add an API Secret for Pager Duty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny nitpick - there's a border above 'options' on the late run tab that I don't think we want/need. it's especially obvious in dark mode.
This PR:
Current UI:
Otherwise looks good to me. Once those small changes are made, I'd welcome a final review from @znicholasbrown, @whimsicallyson and/or @pleek91
Looks good to me - can we get another approval before merging to staging? @pleek91 @whimsicallyson (Once that review is done, if you're happy you can remove the do not merge label) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @stackoverfloweth
my only question/comment is how it works if there are more tab options than the width of the card. does it overflow properly in the horizontal, or do we wend up with the same issue that we had with the old implementation? |
@whimsicallyson Great point, yes it does overflow properly! That's built into v-tabs https://vuetifyjs.com/en/components/tabs/#dynamic-tabs. |
PR Checklist:
CHANGELOG.md
Describe this PR