fix segfault on gcp metadata server check #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal/gcs/gcs.go
Outdated
Comment on lines
22
to
28
| if err != nil { | ||
| return false | ||
| } | ||
|
|
||
| defer resp.Body.Close() | ||
|
|
||
| return true |
There was a problem hiding this comment.
I would suggest to avoid the return true, and return false pattern
Suggested change
| if err != nil { | |
| return false | |
| } | |
| defer resp.Body.Close() | |
| return true | |
| if resp != nil && resp.Body != nil { | |
| defer resp.Body.Close() | |
| } | |
| return err == nil |
luisdavim
reviewed
Jul 14, 2024
| resp.Body.Close() | ||
|
|
||
| if resp != nil && resp.Body != nil { | ||
| defer resp.Body.Close() |
There was a problem hiding this comment.
Doesn't need to be deferred, the body is not going to be used anymore.
| @@ -18,7 +18,11 @@ var style aurora.Aurora | |||
|
|
|||
| func IsRunningInGCP() bool { | |||
| resp, err := http.Get("http://metadata.google.internal") | |||
| resp.Body.Close() | |||
|
|
|||
| if resp != nil && resp.Body != nil { | |||
There was a problem hiding this comment.
This is ok but I don't think we need to check if the body is nil, only the response.
There was a problem hiding this comment.
If the body is nil the code defer resp.Body.Close() will panic
There was a problem hiding this comment.
Yes but according to the documentation it won't be nil.
luisdavim
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix #909