Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-on to #166 that fixes #172. It consists of 3 commits:
BigDecimal
values from strings. TheBigDecimal
constructor is limited. This commit usesDecimalFormat
for more sophisticated parsing of strings, fixing a handful of tests in the process.FilterableTest
. TheSingleMethodFilter
class is no longer necessary, since junit providesRequest.method
. However, there is also a behavior change here:request.getRunner().getDescription()
gets descriptions for all test methods, whether they pass the filter or not. They are marked appropriately, sorequest.getRunner().testCount()
returns the expected value of 1 in each case, and if you actually run the tests, only 1 is executed.hasMessage
tohasMessageContaining
since junit now returns a numbered list of exception strings.With these changes, all tests pass. Some are noisy; I have not attempted to silence them.