Overlaps with xSQLServer

[rhencke]

There is overlap between this module and https://github.com/PowerShell/xSQLServer/.

For example, MSFT_xSqlServerInstall from this module fulfills the same role as MSFT_xSqlServerSetup from xSQLServer.

Perhaps these two modules could be combined into one?

[vors]

👍

[Matticusau]

I agree, if you read the original DSC Resource Kit notes for xSQLServer it was designed to support System Center installations. I have been working on enhancing this xSqlPs to even more greatly support our best practices for SQL installs, just trying to get it to a point that the team will accept it into the release

[rhencke]

@Matticusau I like your dogs! :)

That's awesome. I have done the same, but unfortunately I'm still working with my employer on getting clearance to submit it back. But, I'd be very very interested in what you are working on there. If you need anyone to hammer on it and try it out let me know!

[DdenBraver]

Just reading past this "issue".
Some time ago I was running into the same issue, and merged the modules xSQLServer and xSQLPs into a custom resource.

@Matticusau as I understand that xSQLServer was created to support System Center installations, it currently still supports much more parameters for the installation, making it easyer to finetune the installations.

I will upload my custom resource as an example if my customer allows me to share the code.

[kilasuit]

@KarolKaczmarek - This should be merged together with xSQLServer Resource for a few reasons

• Simpler Adoption & removes the existing overlap between the two modules.
• Simpler Management & Development to be able to build a single fully featured resource (Ideal end goal)

I'm dedicating some time to work to doing this where I can but this is something that in my opinion we need to start down that path as soon as we can

[Matticusau]

This is a great discussion. I have actually had some discussions around this internally and am continuing those discussions because internally we feel the two should be merged and the view from the community definitely supports that approach too which is helping to drive the discussions. It will need to be a community approach (IMO) and when I have some clarity around how that looks I will provide further guidance.
Matt

[DdenBraver]

@Matticusau If there is any way I could help with this, please let me know.
I have no problem "merging" the 2 resources together, and remove any duplicates if this might help.
Personally I feel that we should continue on the name xSQLServer, as not everything has to be SQLPs based.

[KarolKaczmarek]

Agreed, we should merge xSqlPs into xSQLServer and retire this repo.
I saw @DdenBraver already started working on this with https://github.com/Solvinity/cSQLServer .
Would you or anyone else be willing to drive this and submit PR into xSQLServer?

[Matticusau]

The work to merge into xSqlServer has already been completed for some time (sorry forgot to update this). I will chase up about retiring the repo

[kwirkykat]

@johlju Looks like this module is a duplicate of xSqlServer? Any reason I shouldn't remove/deprecate this module?

[johlju]

@kwirkykat I think we should deprecate this module. There are equivalent resources, and soon to be better resources (IMHO). Might be a good thing to deprecate it for a couple of months and then remove it. So people have a chance to move to the new module.

Resource in xSqlPs	equivalent in xSQLServer
MSFT_xSqlHAEndPoint	MSFT_xSQLServerEndpoint
MSFT_xSqlAlias	MSFT_xSQLServerAlias
MSFT_xSqlHAGroup	MSFT_xSQLServerAlwaysOnAvailabilityGroup + MSFT_xSQLServerAlwaysOnAvailabilityGroupReplica
MSFT_xSqlHAService	MSFT_xSQLServerAlwaysOnService
MSFT_xSqlServerInstall	MSFT_xSQLServerSetup
MSFT_xWaitForSqlHAGroup	MSFT_xWaitForAvailabilityGroup (and might be replaced by MSFT_xSQLServerAlwaysOnAvailabilityGroupReplica)

UPDATE 2017-07-12: Updated table and removed deprecated resource no longer in xSQLServer.

[johlju]

@kwirkykat You may remove this module at anytime. This module is obsolete now!

[andikrueger]

Today I came across the "modified Version" of this module in this azure quickstart template named xSql.
The modified version contains "MicrosoftAzure_xSqlLogin" wich allows the configuration of SQL logins on instance level. This function seems to be missing in xSqlPs and xSqlServer.

@kwirkykat and @johlju: Are there any plans to integrate these modifications in any of the existing or newer xSql modules?

[johlju]

@andikrueger There is xSQLServerLogin resource in the module xSQLServer that can create logins. If you are missing any functionality in that resource, please submit an issue in https://github.com/PowerShell/xSQLServer and we can discuss it there. 😄

[johlju]

@andikrueger That seems to be a subset of resource from different modules compiled for a specific scenario (use case). Deployed to https://azure.microsoft.com/en-us/resources/templates/ by different users. So for them to be added to DSC Resource Kit the authors/owners need to send them in as PR's (Pull Requests).

[kwirkykat]

This module has been deprecated. Leaving this as the only open issue for now.

[johlju]

Closing this as per previous comment. Please reopen or comment if this was closed in error.