Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xSQLServer: Integration tests should use -ErrorAction Stop on Start-DscConfiguration #824

Closed
johlju opened this issue Sep 19, 2017 · 0 comments · Fixed by #826
Closed

xSQLServer: Integration tests should use -ErrorAction Stop on Start-DscConfiguration #824

johlju opened this issue Sep 19, 2017 · 0 comments · Fixed by #826
Assignees
@johlju
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Sep 19, 2017

Details of the scenario you tried and the problem that is occurring:
If -ErrorAction Stop is not used in integration tests for the cmdlet Start-DscConfiguration some errors does not throw resulting in passing tests (even if errors are logged).

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Sep 19, 2017
johlju added a commit to johlju/SqlServerDsc that referenced this issue Sep 19, 2017
@johlju
Changes to xSQLServer
d0777f7 
- Changes to xSQLServerAlwaysOnService
  - Fix integration tests. Added ErrorAction 'Stop' to the cmdlet Start-DscConfiguration (issue dsccommunity#824]).
- Changes to xSQLServerSetup
  - Fix integration tests. Added ErrorAction 'Stop' to the cmdlet Start-DscConfiguration (issue dsccommunity#824]).
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Sep 19, 2017
@johlju johlju mentioned this issue Sep 19, 2017
Merged
5 tasks
johlju added a commit to johlju/SqlServerDsc that referenced this issue Sep 19, 2017
@johlju
Changes to xSQLServer
8016d0a 
- Changes to xSQLServerAlwaysOnService
  - Fix integration tests. Added ErrorAction 'Stop' to the cmdlet Start-DscConfiguration (issue dsccommunity#824]).
- Changes to xSQLServerSetup
  - Fix integration tests. Added ErrorAction 'Stop' to the cmdlet Start-DscConfiguration (issue dsccommunity#824]).
johlju added a commit that referenced this issue Sep 20, 2017
@johlju
xSQLServer: Fix integration tests. Added ErrorAction 'Stop' to the cm…
c051158 
…dlet Start-DscConfiguration (#826)

- Changes to xSQLServerAlwaysOnService
  - Fix integration tests. Added ErrorAction 'Stop' to the cmdlet Start-DscConfiguration (issue #824]).
- Changes to xSQLServerSetup
  - Fix integration tests. Added ErrorAction 'Stop' to the cmdlet Start-DscConfiguration (issue #824]).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johlju johlju

Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
1 participant
@johlju