Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xSQLServerNetwork: Localization should change to align with HQRM modules #618

Closed
johlju opened this issue Jun 6, 2017 · 0 comments · Fixed by #887
Closed

xSQLServerNetwork: Localization should change to align with HQRM modules #618

johlju opened this issue Jun 6, 2017 · 0 comments · Fixed by #887
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Jun 6, 2017

Details of the scenario you tried and the problem that is occurring:
Resource should use the same method of localization as HQRM modules (PSDscResource). More information in PR #205.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jun 6, 2017
@nabrond nabrond mentioned this issue Oct 15, 2017
Merged
5 tasks
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Oct 15, 2017
johlju pushed a commit that referenced this issue Oct 17, 2017
@nabrond @johlju
BREAKING CHANGE: xSQLServerNetwork: Support for configuring SQL Serve…
4a84423 
…r to use a static port (#887)

- Changes to xSQLServerNetwork
  - BREAKING CHANGE: Renamed parameter TcpDynamicPorts to TcpDynamicPort and
    changed type to Boolean (issue #534).
  - Resolved issue when switching from dynamic to static port.
    configuration (issue #534).
  - Added localization (en-US) for all strings in resource and unit tests
    (issue #618).
  - Updated examples to reflect new parameters.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING CHANGE: xSQLServerNetwork: Support for configuring SQL Server to use a static port
1 participant
@johlju