Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xClusterDisk: Localization should change to align with HQRM modules #84

Closed
johlju opened this issue Jul 2, 2017 · 0 comments · Fixed by #111
Closed

xClusterDisk: Localization should change to align with HQRM modules #84

johlju opened this issue Jul 2, 2017 · 0 comments · Fixed by #111
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Jul 2, 2017

Details of the scenario you tried and the problem that is occurring:
Resource should use the same method of localization as HQRM modules (PSDscResource).

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System and PowerShell the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jul 2, 2017
johlju added a commit to johlju/FailoverClusterDsc that referenced this issue Jul 9, 2017
@johlju
- Changes to xFailOverCluster
2af55be 
  - Added a common resource helper module with helper functions for localization.
    - Added helper functions; Get-LocalizedData, New-InvalidResultException, New-ObjectNotFoundException, InvalidOperationException and InvalidArgumentException.
  - Fixed lint error MD034 and fixed typos in README.md.
- Changes to xClusterDisk
  - Enabled localization for all strings (issue dsccommunity#84).
- Changes to xClusterPreferredOwner
  - Replace an URL which describes more generic the Role setting for xClusterNetwork.
@johlju johlju mentioned this issue Jul 9, 2017
Merged
5 tasks
johlju added a commit to johlju/FailoverClusterDsc that referenced this issue Jul 14, 2017
@johlju
- Changes to xFailOverCluster
ef20980 
  - Added a common resource helper module with helper functions for localization.
    - Added helper functions; Get-LocalizedData, New-InvalidResultException, New-ObjectNotFoundException, InvalidOperationException and InvalidArgumentException.
  - Fixed lint error MD034 and fixed typos in README.md.
- Changes to xClusterDisk
  - Enabled localization for all strings (issue dsccommunity#84).
- Changes to xClusterPreferredOwner
  - Replace an URL which describes more generic the Role setting for xClusterNetwork.
johlju added a commit that referenced this issue Jul 18, 2017
@johlju
xFailOverCluster: Localization support, localized strings in xCluster…
bff34fb 
…Disk and some cleanup (#111)

- Changes to xFailOverCluster
  - Added a common resource helper module with helper functions for localization.
    - Added helper functions; Get-LocalizedData, New-InvalidResultException,
      New-ObjectNotFoundException, New-InvalidOperationException and
      New-InvalidArgumentException.
  - Fixed lint error MD034 and fixed typos in README.md.
- Changes to xClusterDisk
  - Enabled localization for all strings ([issue #84](#84)).
- Changes to xClusterNetwork
  - Replaced the URL for the parameter Role in README.md. The new URL is a more
    generic description of the possible settings for the Role parameter. The
    previous URL was still correct but focused on Hyper-V in particular.
  - Fixed typos in parameter descriptions in README.md.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
1 participant
@johlju