Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xClusterPreferredOwner: Unit tests does not use the correct template and folder structure is wrong #76

Closed
johlju opened this issue Jun 21, 2017 · 0 comments · Fixed by #98
Closed

xClusterPreferredOwner: Unit tests does not use the correct template and folder structure is wrong #76

johlju opened this issue Jun 21, 2017 · 0 comments · Fixed by #98
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Jun 21, 2017

Details of the scenario you tried and the problem that is occurring:
Unit tests does not use the correct template and folder structure is wrong

I suggest change so the correct template is used for the unit tests, and that the correct folder structure is used.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System and PowerShell the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jun 21, 2017
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jul 6, 2017
johlju added a commit to johlju/FailoverClusterDsc that referenced this issue Jul 6, 2017
@johlju
Changes to xClusterPreferredOwner
078d0f8 
Refactored the unit test for this resource to use stubs and increase coverage (issue dsccommunity#76).
@johlju johlju mentioned this issue Jul 6, 2017
Merged
5 tasks
@johlju johlju closed this as completed in #98 Jul 7, 2017
johlju added a commit that referenced this issue Jul 7, 2017
@johlju
xClusterPreferredOwner: Refactor unit test (#98)
c625b02 
- Changes to xClusterPreferredOwner
  - Refactored the unit test for this resource to use stubs and increase coverage
    (issue #76).
  - Changed the code to be more aligned with the style guideline.
  - Added examples (issue #52)
    - 1-AddPreferredOwner.ps1
    - 2-RemovePreferredOwner.ps1
  - Added links to examples from README.md.
@johlju johlju removed their assignment Jul 29, 2017
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xClusterPreferredOwner: Refactor unit test johlju/FailoverClusterDsc
1 participant
@johlju