Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md: Parameters should list their class (data type) and type qualifier #58

Closed
johlju opened this issue Jun 13, 2017 · 0 comments
Closed

README.md: Parameters should list their class (data type) and type qualifier #58

johlju opened this issue Jun 13, 2017 · 0 comments
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Jun 13, 2017 •
edited
Loading

I suggest to add all parameters like this.

  • [String] ClusterGroup (Key): Name of the cluster group.
  • [String] ClusterName (Key): Name of the cluster.
  • [String[]] Nodes (Required): The nodes to set as owners.
  • [String[]] ClusterResources (Write): The resources to set preferred owner on.
  • [String[]] Ensure (Write): If the preferred owners should be present or absent. { Present | Absent }
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jun 13, 2017
@johlju johlju self-assigned this Jun 14, 2017
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jun 14, 2017
johlju added a commit to johlju/FailoverClusterDsc that referenced this issue Jun 14, 2017
@johlju
Fixed review comments at r2
e043f4d 
Changes to xFailOverCluster
  - Removed Credential parameter from parameter list for xWaitForCluster. Parameter Credential does not exist in the schema.mof of the resource (issue dsccommunity#62).
  - Now all parameters in the README.md list their data type and type qualifier (issue dsccommunity#58.)
  - Added Import-DscResource to example in README.md.
@johlju johlju mentioned this issue Jun 14, 2017
Merged
johlju added a commit to johlju/FailoverClusterDsc that referenced this issue Jun 14, 2017
@johlju
Fixed review comments at r2
20e35f1 
Changes to xFailOverCluster
  - Removed Credential parameter from parameter list for xWaitForCluster. Parameter Credential does not exist in the schema.mof of the resource (issue dsccommunity#62).
  - Now all parameters in the README.md list their data type and type qualifier (issue dsccommunity#58.)
  - Added Import-DscResource to example in README.md.
bgelens added a commit that referenced this issue Jun 14, 2017
@bgelens
Merge pull request #60 from johlju/changes-to-xFailOverCluster
71849b1 
xFailOverCluster: Updating README.md, adding CHANGELOG.md, adding GitHub templates
Fixes #44
Fixes #43
Fixes #36
Fixes #45
Fixes #48
Fixes #51
Fixes #56
Fixes #62
Fixes #58
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jun 14, 2017
@johlju johlju removed their assignment Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johlju