xActiveDirectory: Requirements section #399

JamesFrierson1 · 2019-06-26T16:12:38Z

Pull Request (PR) description

Added a Requirements section to every DSCResource README with the bullet point stating "Target machine must be running Windows Server 2008 R2 or later".

This Pull Request (PR) fixes the following issues

Fixes #394

Task list

Added an entry under the Unreleased section in the CHANGELOG.md.

This change is

johlju · 2019-06-26T16:53:12Z

@JamesFrierson1 Could you please resolve the merge conflicts? It seems your working branch is not using the latest changes merged into the dev branch.

See here how to resolve merge conflicts
https://github.com/PowerShell/DscResources/blob/master/GettingStartedWithGitHub.md#resolve-merge-conflicts

codecov-io · 2019-06-26T17:17:41Z

Codecov Report

Merging #399 into dev will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##            dev   #399   +/-   ##
===================================
  Coverage    92%    92%           
===================================
  Files        20     20           
  Lines      2538   2538           
  Branches     10     10           
===================================
  Hits       2345   2345           
  Misses      183    183           
  Partials     10     10

JamesFrierson1

Reviewable status: 8 of 18 files reviewed, 22 unresolved discussions (waiting on @JamesFrierson1 and @johlju)

CHANGELOG.md, line 32 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

  - Deleted the obsolete xActiveDirectory_TechNetDocumentation.html file
I think this row should be removed since it is already present two rows down.

Done.

CHANGELOG.md, line 33 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

DSCResource
I think we should write it like this "...DSC resource...", also please add a full stop .at he end of the sentence.

Done.

CHANGELOG.md, line 33 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Added a Requirements section to every DSCResource README with the bullet point stating "Target machine must be running Windows Server 2008 R2 or later"
Please add a reference to the issue this change closes, see other entry for example.

Done.

DSCResources/MSFT_xADDomainTrust/README.md, line 2 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Please add back the empty row after this section.

Done.

DSCResources/MSFT_xADDomainTrust/README.md, line 4 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

## Requirements
Please add an the empty row after this section.

Done.

DSCResources/MSFT_xADKDSKey/README.md, line 1 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

## Description
Please add an the empty row after this section.

Done.

DSCResources/MSFT_xADKDSKey/README.md, line 4 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

## Requirements
Please add an the empty row after this section.

Done.

DSCResources/MSFT_xADManagedServiceAccount/README.md, line 1 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

## Description
Please add an the empty row after this section.

Done.

DSCResources/MSFT_xADManagedServiceAccount/README.md, line 5 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

## Requirements
Please add an the empty row after this section.

Done.

DSCResources/MSFT_xADOrganizationalUnit/README.md, line 1 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

# Description
Please add an the empty row after this section.

Done.

DSCResources/MSFT_xADOrganizationalUnit/README.md, line 4 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

## Requirements
Please add an the empty row after this section.

Done.

DSCResources/MSFT_xADReplicationSite/README.md, line 1 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

# Description
Please add an the empty row after this section.

Done.

DSCResources/MSFT_xADReplicationSite/README.md, line 4 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

## Requirements
Please add an the empty row after this section.

Done.

DSCResources/MSFT_xADReplicationSiteLink/README.md, line 1 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

# Description
Please add an the empty row after this section.

Done.

DSCResources/MSFT_xADReplicationSiteLink/README.md, line 4 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

## Requirements
Please add an the empty row after this section.

Done.

DSCResources/MSFT_xADServicePrincipalName/README.md, line 1 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

# Description
Please add an the empty row after this section.

Done.

DSCResources/MSFT_xADServicePrincipalName/README.md, line 4 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

## Requirements
Please add an the empty row after this section.

Done.

DSCResources/MSFT_xADUser/README.md, line 1 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

# Description
Please add an the empty row after this section.

Done.

DSCResources/MSFT_xADUser/README.md, line 4 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

## Requirements
Please add an the empty row after this section.

Done.

DSCResources/MSFT_xWaitForADDomain/README.md, line 1 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

# Description
Please add an the empty row after this section.

Done.

DSCResources/MSFT_xWaitForADDomain/README.md, line 4 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

## Requirements
Please add an the empty row after this section.

Done.

JamesFrierson1

Reviewable status: 8 of 18 files reviewed, 22 unresolved discussions (waiting on @johlju)

a discussion (no related file):

Previously, johlju (Johan Ljunggren) wrote…

Can you please resolve the failing tests here https://ci.appveyor.com/project/PowerShell/xactivedirectory/builds/25563778?fullLog=true#L307

Done.

JamesFrierson1 · 2019-06-26T18:46:16Z

Thank you for your patience, @johlju ! I added the proper spacing per your instructions and updated my changlog entry with a link to the issue

johlju

No worries, this was nothing. 🙂 Thank you for this contribution! Great work! 🙂

Reviewed 9 of 9 files at r4, 1 of 1 files at r5.
Reviewable status: complete! all files reviewed, all discussions resolved

johlju

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @JamesFrierson1)

CHANGELOG.md, line 34 at r5 (raw file):

      are not in desired state when verbose output is enabled.
  - Update all unit tests to latest unit test template.
  - Added a Requirements section to every DSC resource README with the bullet point stating "Target machine must be running Windows Server 2008 R2 or later" ([issue #399](https://github.com/PowerShell/xActiveDirectory/pull/399)).

@JamesFrierson1 Actually Katie just released a new version of this module, so we need to movie this entry back up to the unreleased section.
Add a - Changes to xActiveDirectory entry too and put it under. 🙂

I was hoping to get this one in before she did that. Either way, once this PR is merged in the dev branch I will update the wiki with this change.

JamesFrierson1

Reviewable status: 17 of 18 files reviewed, 1 unresolved discussion (waiting on @johlju)

CHANGELOG.md, line 34 at r5 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

@JamesFrierson1 Actually Katie just released a new version of this module, so we need to movie this entry back up to the unreleased section.
Add a - Changes to xActiveDirectory entry too and put it under. 🙂

I was hoping to get this one in before she did that. Either way, once this PR is merged in the dev branch I will update the wiki with this change.

Done.

johlju

Reviewed 1 of 1 files at r6.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @JamesFrierson1)

a discussion (no related file):
There are some failing tests here, could yo look at those?
https://ci.appveyor.com/project/PowerShell/xactivedirectory/builds/25567306?fullLog=true#L1163

DSCResources/MSFT_xADManagedServiceAccount/README.md, line 6 at r6 (raw file):

## Requirements

Can we add a requirement that "Group Managed Service Accounts need at least one Windows Server 2012 Domain Controller.".

JamesFrierson1

Reviewable status: 15 of 18 files reviewed, 2 unresolved discussions (waiting on @JamesFrierson1 and @johlju)

DSCResources/MSFT_xADManagedServiceAccount/README.md, line 6 at r6 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

## Requirements
Can we add a requirement that "Group Managed Service Accounts need at least one Windows Server 2012 Domain Controller.".

Done.

JamesFrierson1

Reviewable status: 14 of 18 files reviewed, 2 unresolved discussions (waiting on @johlju)

a discussion (no related file):

Previously, johlju (Johan Ljunggren) wrote…

There are some failing tests here, could yo look at those?
https://ci.appveyor.com/project/PowerShell/xactivedirectory/builds/25567306?fullLog=true#L1163

Done.

johlju

Just one more tiny comment, then I think this is ready to be merged. :)

Reviewed 4 of 4 files at r7.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @JamesFrierson1)

CHANGELOG.md, line 7 at r7 (raw file):

- Changes to xActiveDirectory
  - Added a Requirements section to every DSC resource README with the bullet point stating "Target machine must be running Windows Server 2008 R2 or later" ([issue #399](https://github.com/PowerShell/xActiveDirectory/pull/399)).
  - Added a line to the xADManagedServiceAccount DSC resource README reading "Group Managed Service Accounts need at least one Windows Server 2012 Domain Controller" ([issue #399](https://github.com/PowerShell/xActiveDirectory/pull/399)).

Can we add this second entry under a Changes to xADManagedServiceAccount bullet item so we it is easier to read the changes for a particular resource? The first entry is good where it is.

JamesFrierson1

Reviewable status: 17 of 18 files reviewed, 1 unresolved discussion (waiting on @johlju)

CHANGELOG.md, line 7 at r7 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Can we add this second entry under a Changes to xADManagedServiceAccount bullet item so we it is easier to read the changes for a particular resource? The first entry is good where it is.

Done.

johlju

Reviewed 1 of 1 files at r8.
Reviewable status: complete! all files reviewed, all discussions resolved

johlju · 2019-06-27T15:24:29Z

@JamesFrierson1 Thank you for this! 😃

JamesFrierson1 · 2019-06-27T16:20:02Z

You're very welcome @joeyaiello ! My pleasure 😄

JamesFrierson1 added 25 commits June 8, 2019 12:17

Delete xActiveDirectory_TechNetDocumentation.html

a7514a3

Update CHANGELOG.md

942251d

Update README.md

42564be

Update README.md

ceb172a

Update README.md

b2566ad

Update README.md

51d5559

Update README.md

5044a12

Update README.md

43a7287

Update README.md

6af6655

Update README.md

21e5d53

Update README.md

7508fc9

Update README.md

da66a74

Update README.md

52992d5

Update README.md

a89f72a

Update README.md

22dab79

Update README.md

22cbc79

Update README.md

79bcf56

Update README.md

eae4a75

Update README.md

37ceaa1

Update README.md

40c99ad

Update README.md

ee495f7

Update README.md

87fc624

Update CHANGELOG.md

9bf312c

Update CHANGELOG.md

a1dda81

Update CHANGELOG.md

ddd1dc2

JamesFrierson1 mentioned this pull request Jun 26, 2019

xActiveDirectory: Resource have a requirements section (in wiki README.md) #394

Closed

johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Jun 26, 2019

Merge branch 'dev' into dev

98050bc

JamesFrierson1 commented Jun 26, 2019

View reviewed changes

Merge branch 'dev' into dev

692c369

johlju added needs review The pull request needs a code review. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Jun 26, 2019

johlju approved these changes Jun 26, 2019

View reviewed changes

johlju requested changes Jun 26, 2019

View reviewed changes

Update CHANGELOG.md

fee595f

JamesFrierson1 commented Jun 26, 2019

View reviewed changes

johlju requested changes Jun 27, 2019

View reviewed changes

JamesFrierson1 added 3 commits June 27, 2019 08:30

Update README.md

fa6f35c

Update README.md

a073778

Update README.md

18206b8

JamesFrierson1 commented Jun 27, 2019

View reviewed changes

JamesFrierson1 added 2 commits June 27, 2019 08:38

Update CHANGELOG.md

ff047e0

Update CHANGELOG.md

2ee54d0

JamesFrierson1 commented Jun 27, 2019

View reviewed changes

johlju requested changes Jun 27, 2019

View reviewed changes

Update CHANGELOG.md

1b4d0ba

JamesFrierson1 commented Jun 27, 2019

View reviewed changes

johlju approved these changes Jun 27, 2019

View reviewed changes

johlju merged commit c5dd281 into dsccommunity:dev Jun 27, 2019

johlju removed the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Jun 27, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

xActiveDirectory: Requirements section #399

xActiveDirectory: Requirements section #399

JamesFrierson1 commented Jun 26, 2019 •

edited by johlju

Loading

johlju commented Jun 26, 2019

codecov-io commented Jun 26, 2019 •

edited

Loading

JamesFrierson1 left a comment

JamesFrierson1 left a comment

JamesFrierson1 commented Jun 26, 2019

johlju left a comment

johlju left a comment

JamesFrierson1 left a comment

johlju left a comment

JamesFrierson1 left a comment

JamesFrierson1 left a comment

johlju left a comment

JamesFrierson1 left a comment

johlju left a comment

johlju commented Jun 27, 2019

JamesFrierson1 commented Jun 27, 2019

xActiveDirectory: Requirements section #399

xActiveDirectory: Requirements section #399

Conversation

JamesFrierson1 commented Jun 26, 2019 • edited by johlju Loading

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

johlju commented Jun 26, 2019

codecov-io commented Jun 26, 2019 • edited Loading

Codecov Report

JamesFrierson1 left a comment

Choose a reason for hiding this comment

JamesFrierson1 left a comment

Choose a reason for hiding this comment

JamesFrierson1 commented Jun 26, 2019

johlju left a comment

Choose a reason for hiding this comment

johlju left a comment

Choose a reason for hiding this comment

JamesFrierson1 left a comment

Choose a reason for hiding this comment

johlju left a comment

Choose a reason for hiding this comment

JamesFrierson1 left a comment

Choose a reason for hiding this comment

JamesFrierson1 left a comment

Choose a reason for hiding this comment

johlju left a comment

Choose a reason for hiding this comment

JamesFrierson1 left a comment

Choose a reason for hiding this comment

johlju left a comment

Choose a reason for hiding this comment

johlju commented Jun 27, 2019

JamesFrierson1 commented Jun 27, 2019

JamesFrierson1 commented Jun 26, 2019 •

edited by johlju

Loading

codecov-io commented Jun 26, 2019 •

edited

Loading