Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSFT_xADCommon.ps1 should be made a module script file (.psm1) #201

Closed
johlju opened this issue Jun 9, 2018 · 0 comments
Closed

MSFT_xADCommon.ps1 should be made a module script file (.psm1) #201

johlju opened this issue Jun 9, 2018 · 0 comments
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Jun 9, 2018

The file MSFT_xADCommon.ps1 is not a module files, instead it's dot sourced by MSFT_xADCommon.psm1, Because it's dot source it's not covered by the code coverage. We should change this so that MSFT_xADCommon.ps1 is renamed to MSFT_xADCommon.psm1 and the old MSFT_xADCommon.psm1 is removed.
@johlju johlju changed the title MSFT_xADCommon.ps1 should be made a module script file (.,psm1) MSFT_xADCommon.ps1 should be made a module script file (.psm1) Jun 9, 2018
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jun 9, 2018
@johlju johlju mentioned this issue Jun 9, 2018
Merged
johlju added a commit that referenced this issue Jun 11, 2018
@johlju
xActiveDirectory: MSFT_xADCommon.ps1 is renamed to MSFT_xADCommon.psm1 (
7f7bb4e 
#202)

- The helper function script file MSFT_xADCommon.ps1 was renamed to MSFT_xADCommon.psm1
  to be a module script file instead. This makes it possible to report code coverage for the helper 
  functions (issue #201).
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Jun 11, 2018
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Apr 19, 2019
@johlju
xActiveDirectory: MSFT_xADCommon.ps1 is renamed to MSFT_xADCommon.psm1 (
a8a02b8 
dsccommunity#202)

- The helper function script file MSFT_xADCommon.ps1 was renamed to MSFT_xADCommon.psm1
  to be a module script file instead. This makes it possible to report code coverage for the helper 
  functions (issue dsccommunity#201).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johlju