Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension preloads DLLs even tho the modules are not used #3912

Open
6 tasks done
PrzemyslawKlys opened this issue Apr 10, 2022 · 3 comments
Open
6 tasks done

Extension preloads DLLs even tho the modules are not used #3912

PrzemyslawKlys opened this issue Apr 10, 2022 · 3 comments

Comments

@PrzemyslawKlys
Copy link
Contributor

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues to ensure it has not already been reported.
  • I have read the troubleshooting guide.
  • I am sure this issue is with the extension itself and does not reproduce in a standalone PowerShell instance.
  • I have verified that I am using the latest version of Visual Studio Code and the PowerShell extension.
  • If this is a security issue, I have read the security issue reporting guidance.

Summary

I am not sure if this is something that can be fixed, but it's been showing up for me very often, a lot for PowerShell 7.3, never for PowerShell 5.1 and sometimes for newer PowerShell versions.

I develop my modules in VSCode. Once I'm happy with the module that it works enough I combine everything, including DLLs, and push it to standard PowerShell module folders so my apps can use it. This is my so-called "production" version that I know works correctly and can be publish to psgallery. But then I continue working with the non-production version in VSCode.

Whenever I open PowerShell 7 and do Import-Module .\Mymodule.psd1 -Force it claims the DLLs are already loaded.

image

Of course the warning comes from my PSM1 where I explicitly detect the error when I try to do Add-Type and prevent it.

I tried tracking it - Whenever I open PowerShell 7 (doesn't seem to show up in 5.1) it seems that it already preloads DLL's. I can see this with:

[System.AppDomain]::CurrentDomain.GetAssemblies() | Where-Object Location | Sort-Object -Property FullName | Select-Object -Property FullName, Location, GlobalAssemblyCache, IsFullyTrusted 

It doesn't happen all the time, but enough time for me to notice. Those DLL's have now loaded

image

But the module itself did not:

image

My understanding is - it happens when I switch between files (just by reading them), not even running and loads DLL's in the background making a problem for development (assuming that I would like to change DLL version for example). So my guess is VSCode PowerShell wants to help me - but at the same time it impacts module development.

While I can deal with it internally I'm guessing a lot of other people may not be as happy.

PowerShell Version

Name                           Value
----                           -----
PSVersion                      7.3.0-preview.3
PSEdition                      Core
GitCommitId                    7.3.0-preview.3
OS                             Microsoft Windows 10.0.22000
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Visual Studio Code Version

1.66.1
8dfae7a5cd50421d10cd99cb873990460525a898
x64

Extension Version

ms-vscode.?[7mpowershell?[[email protected]
ms-vscode.?[7mpowershell?[[email protected]
tobysmith568.run-in-?[7mpowershell?[[email protected]
TylerLeonhardt.vscode-inline-values-?[7mpowershell?[[email protected]

Steps to Reproduce

As described above.

Visuals

No response

Logs

No response

@PrzemyslawKlys PrzemyslawKlys added the Issue-Bug A bug to squash. label Apr 10, 2022
@ghost ghost added the Needs: Triage Maintainer attention needed! label Apr 10, 2022
@JustinGrote
Copy link
Collaborator

Could be intellisense, if you intellisense a portion of a name of a command that's advertised in a module as part of PSModulePath, it'll import it so it can read the help/parameters/etc.

I usually do my module testing (pester etc.) using the "use separate powershell process" aspect, so I don't have to worry about what my "primary" PSIC has in it.

@PrzemyslawKlys
Copy link
Contributor Author

Could be CodeLens, that's why I said it may not be fixable - but it started happening in Preview. Haven't seen this in production version so maybe the extension is just too eager to start (which is understandable if you see my earlier complains🤣).

@SydneyhSmith SydneyhSmith added Area-Symbols & References and removed Needs: Triage Maintainer attention needed! labels Apr 26, 2022
@o-l-a-v
Copy link
Contributor

o-l-a-v commented Aug 29, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants