Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKCS11 Support #1210

Closed
enzain opened this issue Jul 9, 2018 · 7 comments
Closed

PKCS11 Support #1210

enzain opened this issue Jul 9, 2018 · 7 comments

Comments

@enzain
Copy link

enzain commented Jul 9, 2018

Hi,

Not issue - just question

In plans - PKCS11 support?
Without PKCS11 - is no good ...

@NoMoreFood
Copy link

I can't speak for whether it's in the plans, but after enabling the compiler flag it compiled fine and looks like it almost worked for my smart card (C_Login failed: 160). It asked for my PIN and then rejects me. Any reason why we wouldn't want to support this? I can probably figure out what's going wrong pretty easily since I'm familiar with the PKCS libraries from my work on PuTTY-CAC.

@manojampalam I'll take a look at this before my SSPI adventures unless there's a reason we don't want to support PKCS11. Let me know.

@NoMoreFood
Copy link

Update: When/if my other change to rework readpassphrase() is merged (PowerShell/openssh-portable#322), then all we have to do is set ENABLE_PKCS11 in order for PKCS11 support to work. It's possible we don't need change that merged for compiling in Visual Studio 2015, but my development environment is Visual Studio 2017 which seems to cause readpassphrase() to pass back a utf16 string to a function that expects utf8.

@manojampalam
Copy link
Contributor

manojampalam commented Jul 12, 2018

@NoMoreFood, I will follow up and get back (on both - pkcs#11 and readpassphrase()) by end of this week. What PKCS#11 providers are commonly used on Windows?

@NoMoreFood
Copy link

Created a pull request if we want to follow through with this: PowerShell/openssh-portable#331

@enzain enzain closed this as completed Jul 18, 2018
@enzain
Copy link
Author

enzain commented May 3, 2019

Hello all again!

Still not supported PKCS11 today?

@lukojewel
Copy link

Any luck on this?

@enzain
Copy link
Author

enzain commented Jul 17, 2020

Yes, in versions from github now is work fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants