Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor spelling and grammar corrections in README #34

Open
3 tasks done
DevOpsJeremy opened this issue Jan 30, 2024 · 1 comment
Open
3 tasks done

Minor spelling and grammar corrections in README #34

DevOpsJeremy opened this issue Jan 30, 2024 · 1 comment

Comments

@DevOpsJeremy
Copy link

Prerequisites

  • Write a descriptive title.
  • Make sure you are able to repro it on the latest version
  • Search the existing issues.

Steps to reproduce

This fixes minor spelling/grammar mistakes in the README and has no effect on the functionality.

Line 5

Current

There is no throttling mechanism and so all jobs are started immediately and are all run currently.

The intended word here is 'concurrently'. The distinction is important because concurrent operations is the purpose of this module.

Proposed

There is no throttling mechanism and so all jobs are started immediately and are all run concurrently.

Line 9

Current

ThreadJob jobs will tend to run much faster because there is lower overhead and they do not use the remoting serialization system as BackgroundJob jobs do. And they will use up fewer system resources.

This snippet can be reworded for clarity and to fix a minor issue with parallel structure.

Proposed

ThreadJob jobs will tend to run much faster because there is lower overhead and they do not use the remoting serialization system as BackgroundJob jobs do. Additionally, they consume fewer system resources.

Expected behavior

Line 5:
> There is no throttling mechanism and so all jobs are started immediately and are all run concurrently.

Line 9:
> ThreadJob jobs will tend to run much faster because there is lower overhead and they do not use the remoting serialization system as BackgroundJob jobs do. Additionally, they consume fewer system resources.

Actual behavior

Line 5:
> There is no throttling mechanism and so all jobs are started immediately and are all run currently.

The intended word here is 'concurrently'. The distinction is important because _concurrent_ operations is the purpose of this module.

Line 9:
> ThreadJob jobs will tend to run much faster because there is lower overhead and they do not use the remoting serialization system as BackgroundJob jobs do. And they will use up fewer system resources.

This snippet can be reworded for clarity and to fix a minor issue with parallel structure.

Error details

N/A

Environment data

N/A

Version

2.0.3

Visuals

No response

@krzydoug
Copy link

krzydoug commented Apr 13, 2024

they do not use the remoting serialization system as BackgroundJob jobs do.

Still needs a slight adjustment. Either add 'same'

they do not use the same remoting serialization system as BackgroundJob jobs do.

or

they do not use the remoting serialization system that BackgroundJob jobs do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants