Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xSQLServerAlwaysOnAvailabilityGroupDatabaseMembership: Parameter "DatabaseName" should be case insensitive #912

Closed
nabrond opened this issue Nov 21, 2017 · 1 comment · Fixed by #921
Labels
enhancement The issue is an enhancement request.

Comments

@nabrond
Copy link
Contributor

nabrond commented Nov 21, 2017

Details of the scenario you tried and the problem that is occurring:
The property DatabaseName should not use a case-sensitive test to determine whether a database name matches the specified value or pattern.

The DSC configuration that is using the resource (as detailed as possible):

Configuration SampleConfig 
{
    Import-DscResource -ModuleName xSQLServer -Name xSQLServerAlwaysOnAvailabilityGroupDatabaseMembership

    Node localhost 
    {
        xSQLServerAlwaysOnAvailabilityGroupDatabaseMembership 'TestAG-Database-Members'
        {
            AvailabilityGroupName = 'TestAG'
            BackupPath = 'C:\SQL\Backup'
            DatabaseName = 'MyDB'
            SQLInstanceName = 'MSSQLSERVER'
            SQLServer = 'localhost'
            Ensure = 'Present'
        }
    }
}

This configuration should match any combination of case for the name "MyDB". However, only database matching the exact case are considered.

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
Operating System: Windows Server 2012 R2
PowerShell Version: 5.0

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
SQLPS (130)

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
8.2.0.0

@nabrond nabrond changed the title xSQLServerAlwaysOnAvailabilityGroupDatabaseMembership Parameter DatabaseName should be case insensitive xSQLServerAlwaysOnAvailabilityGroupDatabaseMembership Parameter "DatabaseName" should be case insensitive Nov 22, 2017
@johlju johlju changed the title xSQLServerAlwaysOnAvailabilityGroupDatabaseMembership Parameter "DatabaseName" should be case insensitive xSQLServerAlwaysOnAvailabilityGroupDatabaseMembership: Parameter "DatabaseName" should be case insensitive Nov 22, 2017
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Nov 22, 2017
@randomnote1
Copy link
Contributor

Working this one.

johlju pushed a commit that referenced this issue Nov 29, 2017
- Changes to SqlAGDatabase
  - Changed the Get-MatchingDatabaseNames function to be case insensitive when
    matching database names (issue #912).
@vors vors removed the help wanted The issue is up for grabs for anyone in the community. label Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants