Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlServerDsc: Opt-in for the common test for example files #669

Closed
johlju opened this issue Jul 3, 2017 · 1 comment · Fixed by #976
Closed

SqlServerDsc: Opt-in for the common test for example files #669

johlju opened this issue Jul 3, 2017 · 1 comment · Fixed by #976
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Jul 3, 2017

Details of the scenario you tried and the problem that is occurring:
We should opt-in for the common test for markdown files.

To opt-in, create a '.MetaTestOptIn.json' at the root of the repo in the following format:

[
     "Common Tests - Validate Example Files"
]

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jul 3, 2017
@johlju
Copy link
Member Author

johlju commented Jul 3, 2017

To be able to opt-in for this, the old examples need to be changed - see issue #462.

@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Oct 8, 2017
johlju added a commit to johlju/SqlServerDsc that referenced this issue Oct 8, 2017
@johlju
Changes to xSQLServer
af9957d 
- The complete examples that no longer was accurate and referenced resources
  that no longer exist was removed. Accurate examples can be found in each
  specific resource example folder. Examples for installing Failover Cluster
  can be found in the resource examples folders in the xFailOverCluster
  resource module (issue dsccommunity#462).
- A README.md was created under the examples folder to be used as reference how
  to installed certain scenarios (issue dsccommunity#462).
- Removed the specific common test for examples in this repository and instead
  opt-in for the common test in the DscResource.Tests repository (issue dsccommunity#669).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Dec 6, 2017
@johlju
Changes to xSQLServer
1f7f853 
- The complete examples that no longer was accurate and referenced resources
  that no longer exist was removed. Accurate examples can be found in each
  specific resource example folder. Examples for installing Failover Cluster
  can be found in the resource examples folders in the xFailOverCluster
  resource module (issue dsccommunity#462).
- A README.md was created under the examples folder to be used as reference how
  to installed certain scenarios (issue dsccommunity#462).
- Removed the specific common test for examples in this repository and instead
  opt-in for the common test in the DscResource.Tests repository (issue dsccommunity#669).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Dec 6, 2017
@johlju
Changes to SqlServerDsc
1faf96d 
- Removed the local specific common test for compiling examples in this repository
  and instead opt-in for the common test in the DscResource.Tests repository (issue dsccommunity#669).
@johlju johlju changed the title xSQLServer: Opt-in for the common test for example files SqlServerDsc: Opt-in for the common test for example files Dec 22, 2017
@johlju johlju mentioned this issue Dec 22, 2017
Closed
johlju added a commit to johlju/SqlServerDsc that referenced this issue Dec 23, 2017
@johlju
Changes to xSQLServer
1c3f528 
- The complete examples that no longer was accurate and referenced resources
  that no longer exist was removed. Accurate examples can be found in each
  specific resource example folder. Examples for installing Failover Cluster
  can be found in the resource examples folders in the xFailOverCluster
  resource module (issue dsccommunity#462).
- A README.md was created under the examples folder to be used as reference how
  to installed certain scenarios (issue dsccommunity#462).
- Removed the specific common test for examples in this repository and instead
  opt-in for the common test in the DscResource.Tests repository (issue dsccommunity#669).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Dec 23, 2017
@johlju
Changes to SqlServerDsc
5989145 
- Removed the local specific common test for compiling examples in this repository
  and instead opt-in for the common test in the DscResource.Tests repository (issue dsccommunity#669).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Dec 28, 2017
@johlju
Changes to xSQLServer
940470c 
- The complete examples that no longer was accurate and referenced resources
  that no longer exist was removed. Accurate examples can be found in each
  specific resource example folder. Examples for installing Failover Cluster
  can be found in the resource examples folders in the xFailOverCluster
  resource module (issue dsccommunity#462).
- A README.md was created under the examples folder to be used as reference how
  to installed certain scenarios (issue dsccommunity#462).
- Removed the specific common test for examples in this repository and instead
  opt-in for the common test in the DscResource.Tests repository (issue dsccommunity#669).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Dec 28, 2017
@johlju
Changes to SqlServerDsc
c7349bc 
- Removed the local specific common test for compiling examples in this repository
  and instead opt-in for the common test in the DscResource.Tests repository (issue dsccommunity#669).
@johlju johlju mentioned this issue Dec 29, 2017
Merged
5 tasks
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jan 1, 2018
@johlju
Changes to xSQLServer
44cb032 
- The complete examples that no longer was accurate and referenced resources
  that no longer exist was removed. Accurate examples can be found in each
  specific resource example folder. Examples for installing Failover Cluster
  can be found in the resource examples folders in the xFailOverCluster
  resource module (issue dsccommunity#462).
- A README.md was created under the examples folder to be used as reference how
  to installed certain scenarios (issue dsccommunity#462).
- Removed the specific common test for examples in this repository and instead
  opt-in for the common test in the DscResource.Tests repository (issue dsccommunity#669).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jan 1, 2018
@johlju
Changes to SqlServerDsc
3548133 
- Removed the local specific common test for compiling examples in this repository
  and instead opt-in for the common test in the DscResource.Tests repository (issue dsccommunity#669).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jan 4, 2018
@johlju
Changes to xSQLServer
6961981 
- The complete examples that no longer was accurate and referenced resources
  that no longer exist was removed. Accurate examples can be found in each
  specific resource example folder. Examples for installing Failover Cluster
  can be found in the resource examples folders in the xFailOverCluster
  resource module (issue dsccommunity#462).
- A README.md was created under the examples folder to be used as reference how
  to installed certain scenarios (issue dsccommunity#462).
- Removed the specific common test for examples in this repository and instead
  opt-in for the common test in the DscResource.Tests repository (issue dsccommunity#669).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jan 4, 2018
@johlju
Changes to SqlServerDsc
b9c503f 
- Removed the local specific common test for compiling examples in this repository
  and instead opt-in for the common test in the DscResource.Tests repository (issue dsccommunity#669).
johlju added a commit that referenced this issue Jan 4, 2018
@johlju
SqlServerDsc: Remove obsolete examples (#976)
de60265 
- Changes to SqlServerDsc
  - The complete examples were removed. They were no longer accurate and some
    referenced resources that no longer exist. Accurate examples can be found
    in each specific resource example folder. Examples for installing Failover Cluster
    can be found in the resource examples folders in the xFailOverCluster
    resource module (issue #462).
  - A README.md was created under the Examples folder to be used as reference how
    to install certain scenarios (issue #462).
  - Removed the local specific common test for compiling examples in this repository
    and instead opted-in for the common test in the 'DscResource.Tests' repository (issue #669).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlServerDsc: Remove obsolete examples johlju/SqlServerDsc
1 participant
@johlju