Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect capitalization of 'If' statement in MSFT_SqlSetup.psm1 #1387

Closed
PlagueHO opened this issue Jul 6, 2019 · 2 comments · Fixed by #1388
Closed

Incorrect capitalization of 'If' statement in MSFT_SqlSetup.psm1 #1387

PlagueHO opened this issue Jul 6, 2019 · 2 comments · Fixed by #1388
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@PlagueHO
Copy link
Member

PlagueHO commented Jul 6, 2019

@johlju - I picked this up when implementing the new PSSA tests to check capitalization on statements:

This line has incorrect style (capital I in 'If').
@PlagueHO PlagueHO mentioned this issue Jul 6, 2019
Merged
9 tasks
@johlju
Copy link
Member

johlju commented Jul 6, 2019 •
edited
Loading

Thanks for that! Looking forward to that common test! There are probably more.

@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jul 6, 2019
@PlagueHO
Copy link
Member Author

PlagueHO commented Jul 6, 2019

Yep, it should save us a fair amount of PR comments 😁

johlju pushed a commit that referenced this issue Jul 6, 2019
@PlagueHO @johlju
SqlSetup: Fix minor style violation (#1388)
2d37a93 
- Changes to SqlSetup
  - Correct minor style violation (issue #1387).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlSetup: Fix minor style violation
2 participants
@johlju @PlagueHO