Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlSetup: Missing Configuration Feature/Options : Tempdb File Configuration #1167

Closed
mdaniou opened this issue Jun 30, 2018 · 13 comments · Fixed by #1242
Closed

SqlSetup: Missing Configuration Feature/Options : Tempdb File Configuration #1167

mdaniou opened this issue Jun 30, 2018 · 13 comments · Fixed by #1242
Labels
enhancement The issue is an enhancement request.

Comments

@mdaniou
Copy link
Contributor

mdaniou commented Jun 30, 2018

Details of the scenario you tried and the problem that is occurring

This issue is created to bring some improvements to the SqlSetup DSC Configuration. The idea is to report all the missing options in the resource to be allow the installation of all the features and to use all the options available in the SQL Server installer.

Options to add to the DSC Resource :

/SQLTEMPDBFILECOUNT
/SQLTEMPDBFILESIZE
/SQLTEMPDBFILEGROWTH
/SQLTEMPDBLOGFILESIZE
/SQLTEMPDBLOGFILEGROWTH

The DSC configuration that is using the resource (as detailed as possible)

SqlSetup

Version of the operating system and PowerShell the target node is running

Windows Server 2012/2012R2/2016

SQL Server edition and version the target node is running

SQL Server 2016/2017

What SQL Server PowerShell modules, and which version, are present on the target node.

Most recent version

Version of the DSC module you're using, or write 'dev' if you're using current dev branch

Most recent version

@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jun 30, 2018
@mdaniou
Copy link
Contributor Author

mdaniou commented Aug 31, 2018

@johlju could you please move this card to In Progress.
I am going to try to work on it.

@johlju
Copy link
Member

johlju commented Aug 31, 2018

@mdaniou Done! 😃

@mdaniou
Copy link
Contributor Author

mdaniou commented Aug 31, 2018

👍

@SQLHorizons
Copy link
Contributor

@mdaniou In my private repo I have a tempdb class that now using to configure tempdb, happy to bring this to the party but may need some assistance in meeting your code standards and converting it to run as DSC. Happy to discuss

@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Sep 24, 2018
@SQLHorizons
Copy link
Contributor

@johlju see tempdb.ps1

@johlju
Copy link
Member

johlju commented Sep 27, 2018

@SQLHorizons love to look at that, but that link goes to a private repo (I got the invite, but haven't accepted yet) - since @mdaniou is working on this I think it would be better if you could share the code (and obfuscated any sensitive information) in a public gist, and under MIT license (add a LICENSE.md file to the gist as well). Then @mdaniou could see if it help him in his work.

@mdaniou how are your progression with this issue? No rush, just curious 😃

@mdaniou
Copy link
Contributor Author

mdaniou commented Sep 27, 2018

Hi @SQLHorizons @johlju,

I didn't start it yet. So feel free to take this on board. I was planning to work on it in October as I need to deploy a new environment under SQL2016

@adamrushuk
Copy link
Contributor

Was looking for this feature, so would be awesome when it is supported. Keep up the good work guys :)

@mdaniou
Copy link
Contributor Author

mdaniou commented Sep 29, 2018

Don't worry I need it too asap so I'll get into this one during October hopefully.
I'm quite busy right now ... :)

@SQLHorizons
Copy link
Contributor

@johlju
Copy link
Member

johlju commented Oct 10, 2018

@SQLHorizons Thanks for that! @mdaniou did the code help you in any way?

@mdaniou
Copy link
Contributor Author

mdaniou commented Oct 10, 2018

@johlju I love the way @SQLHorizons uses the class to configure tempdb. I'll see what I can pick from the code however, I don't want to over-engineer it. I think that I should just add few rows like for the other switches. The simpler the better.

@johlju
Copy link
Member

johlju commented Oct 10, 2018

@mdaniou Agreed. If we need maintain the tempdb there should be a new resource that does that.

johlju pushed a commit that referenced this issue Jan 28, 2019
- Changes to SqlSetup
  - Add parameters to configure the Tempdb files during the installation of the instance.
    The new parameters are SqlTempdbFileCount, SqlTempdbFileSize, SqlTempdbFileGrowth,
    SqlTempdbLogFileSize and SqlTempdbLogFileGrowth (issue #1167).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants