Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates all state-changing commands to be silent by default (with -Passthru) #276

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

HowardWolosky
Copy link
Member

Description

All state-changing commands (with the exception of New-*) are now silent by default. Users can pass-in -PassThru to make them return the result that used to be returned by default.

Users can revert back to the previous behavior by leveraging the new configuration value: DefaultPassThru.

Issues Fixed

Resolves #217

References

n/a

Checklist

  • You actually ran the code that you just wrote, especially if you did just "one last quick change".
  • Comment-based help added/updated, including examples.
  • Static analysis is reporting back clean.
  • New/changed code adheres to our coding guidelines.
  • Formatters were created for any new types being added.
  • New/changed code continues to support the pipeline.
  • Changes to the manifest file follow the manifest guidance.
  • Unit tests were added/updated and are all passing. See testing guidelines. This includes making sure that all pipeline input variations have been covered.
  • Relevant usage examples have been added/updated in USAGE.md.
  • If desired, ensure your name is added to our Contributors list

@HowardWolosky HowardWolosky added enhancement An issue or pull request introducing new functionality to the project. breaking change This includes a change in existing published module behavior. labels Aug 13, 2020
@HowardWolosky
Copy link
Member Author

/azp run PowerShellForGitHub-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HowardWolosky
Copy link
Member Author

/cc: @TylerLeonhardt

…ssThru)

All state-changing commands (with the exception of New-*) are now
silent by default.  Users can pass-in `-PassThru` to make them return
the result that used to be returned by default.

Users can revert back to the previous behavior by leveraging the new
configuration value: DefaultPassThru.

Resolves microsoft#217
@HowardWolosky
Copy link
Member Author

/azp run PowerShellForGitHub-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HowardWolosky HowardWolosky merged commit 9600fc2 into microsoft:master Aug 14, 2020
@HowardWolosky HowardWolosky deleted the passThru branch August 14, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This includes a change in existing published module behavior. enhancement An issue or pull request introducing new functionality to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement -PassThru for all Set-* cmdlets
1 participant