Save & restore the state of [Net.ServicePointManager]::SecurityProtocol #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HowardWolosky
requested changes
Jun 15, 2020
There was a problem hiding this comment.
Thanks for taking on this change!
Invoke-WebRequest will throw an exception if it doesn't return back a successful result. You're going to need to capture the current securityProtocol outside the scope of the try, and then you'll need to restore it within the context of a finally for that try/catch/finally expression in order for the change to be robust.
Thanks again!
HowardWolosky
requested changes
Jun 16, 2020
HowardWolosky
approved these changes
Jun 18, 2020
|
/azp run PowerShellForGitHub-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run PowerShellForGitHub-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Save & restore the state of [Net.ServicePointManager]::SecurityProtocol
Issues Fixed
Fixes #230
References
Checklist
Comment-based help added/updated, including examples.Changes to the manifest file follow the manifest guidance.Unit tests were added/updated and are all passing. See testing guidelines.Relevant usage examples have been added/updated in USAGE.md.