PowerShellForGitHub: Disable Progress Bar for Invoke-WebRequest

[X-Guardian]

Description

This PR disables the PowerShell progress bar for the Invoke-WebRequest cmdlet calls in the Invoke-GHRestMethod and Invoke-SendTelemetryEvent functions due to known performance issues in PowerShell 5.1.

Issues Fixed

• Fixes PowerShellForGitHub: Suggest Disabling ProgressBar when Calling Invoke-WebRequest #227

References

Progress bar can significantly impact cmdlet performance.

Checklist

• You actually ran the code that you just wrote, especially if you did just "one last quick change".
• Comment-based help added/updated, including examples.
• Static analysis is reporting back clean.
• New/changed code adheres to our coding guidelines.
• Changes to the manifest file follow the manifest guidance.
• Unit tests were added/updated and are all passing. See testing guidelines.
• Relevant usage examples have been added/updated in USAGE.md.
• If desired, ensure your name is added to our Contributors list

[HowardWolosky]

Thanks for the quick fix. I think we need to consider the failure scenario though to make sure that we're not accidentally making a permanent change to the user's preferences.

[X-Guardian]

I was still getting a progress bar 'flicker' with NoStatus set, and I tracked it down to the Invoke-WebRequest calls in the Telemetry module, so I have added the same code to disable the progress bar to that module too.

[HowardWolosky]

I was still getting a progress bar 'flicker' with NoStatus set, and I tracked it down to the Invoke-WebRequest calls in the Telemetry module, so I have added the same code to disable the progress bar to that module too.

I had been seeing that too and was wondering where it was coming from. Glad you tracked it down.

It is a shame that there's duplicated code across Invoke-GHRestMethod and Invoke-SendTelemetryEvent, but refactoring between those two was difficult, and in the end I wanted to see if I could keep that file as isolated as possible so that it could be more easily re-purposed by others in other projects. I'm intending to write something up on that (and possibly split it off into another project) at some point.

[HowardWolosky]

Thanks for this. Will get it merged in later today. CI queue is a bit backed-up at the moment.

[X-Guardian]

Could you not create two more GitHub accounts/organizations, to have one for each test environment (Windows, Linux, MacOS)? The pipeline jobs could run in parallel then, with no impact on each other.

It would reduce the CI runtime from an hour to approx 20 mins.

[HowardWolosky]

Could you not create two more GitHub accounts/organizations, to have one for each test environment (Windows, Linux, MacOS)? The pipeline jobs could run in parallel then, with no impact on each other.

It would reduce the CI runtime from an hour to approx 20 mins.

Let's see how well this works.... #231.

[HowardWolosky]

/azp run PowerShellForGitHub-CI

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).