Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter rules list is hard-coded #1282

Open
travisclagrone opened this issue Jul 7, 2019 · 1 comment
Open

Formatter rules list is hard-coded #1282

travisclagrone opened this issue Jul 7, 2019 · 1 comment

Comments

@travisclagrone
Copy link
Contributor

This is technical debt.

The formatter has a list of hard-coded rules, and it can only execute those. It should be refactored to enable the run-time specification of rules via settings. However, more research is needed to determine is there is a necessary reason the rules are hard-coded. See #1277 (comment) and #1277 (comment) for more details.

@bergmeister
Copy link
Collaborator

Yes, thanks.
Just to make it clear: Although hard-coding is not nice, the bigger problem is that that somehow Invoke-Formatter can only choose from those rules. The biggest improvement would be if someone specifies settings, they are actually applied and the hard coded list would only be left for the purpose of defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants