From 2ff8b5d512ceabfd523eda7827f95c30c49e2b0e Mon Sep 17 00:00:00 2001
From: Robert Holt <roholt@microsoft.com>
Date: Thu, 14 Feb 2019 10:48:45 -0800
Subject: [PATCH] Make new error messages into resource strings

---
 .../UseCompatibleCommands.cs                  |  4 +-
 .../CompatibilityRules/UseCompatibleTypes.cs  |  4 +-
 Rules/Strings.Designer.cs                     | 39 ++++++++++++++++---
 Rules/Strings.resx                            | 11 +++++-
 4 files changed, 47 insertions(+), 11 deletions(-)

diff --git a/Rules/CompatibilityRules/UseCompatibleCommands.cs b/Rules/CompatibilityRules/UseCompatibleCommands.cs
index b8d7db85f..888ce707a 100644
--- a/Rules/CompatibilityRules/UseCompatibleCommands.cs
+++ b/Rules/CompatibilityRules/UseCompatibleCommands.cs
@@ -231,7 +231,7 @@ public static CommandCompatibilityDiagnostic Create(
         {
             string message = string.Format(
                 CultureInfo.CurrentCulture,
-                Strings.UseCompatibleCommandsError,
+                Strings.UseCompatibleCommandsCommandError,
                 commandName,
                 platform.PowerShell.Version,
                 platform.OperatingSystem.FriendlyName);
@@ -269,7 +269,7 @@ public static CommandCompatibilityDiagnostic CreateForParameter(
         {
             string message = string.Format(
                 CultureInfo.CurrentCulture,
-                "The parameter '{0}' is not available for command '{1}' in PowerShell '{2}' on '{3}'",
+                Strings.UseCompatibleCommandsParameterError,
                 parameterName,
                 commandName,
                 platform.PowerShell.Version,
diff --git a/Rules/CompatibilityRules/UseCompatibleTypes.cs b/Rules/CompatibilityRules/UseCompatibleTypes.cs
index 9b1d7638a..e2ad774e9 100644
--- a/Rules/CompatibilityRules/UseCompatibleTypes.cs
+++ b/Rules/CompatibilityRules/UseCompatibleTypes.cs
@@ -603,7 +603,7 @@ public static TypeCompatibilityDiagnostic CreateForStaticMethod(
         {
             string message = String.Format(
                 CultureInfo.CurrentCulture,
-                "The method '{0}' on type '{1}' is not available in PowerShell {2} on platform '{3}'",
+                Strings.UseCompatibleTypesMethodError,
                 methodName,
                 typeName,
                 platform.PowerShell.Version,
@@ -645,7 +645,7 @@ public static TypeCompatibilityDiagnostic CreateForStaticProperty(
         {
             string message = String.Format(
                 CultureInfo.CurrentCulture,
-                "The member '{0}' on type '{1}' is not available in PowerShell {2} on platform '{3}'",
+                Strings.UseCompatibleTypesMemberError,
                 propertyName,
                 typeName,
                 platform.PowerShell.Version,
diff --git a/Rules/Strings.Designer.cs b/Rules/Strings.Designer.cs
index f54c8e336..49fd55aea 100644
--- a/Rules/Strings.Designer.cs
+++ b/Rules/Strings.Designer.cs
@@ -2049,6 +2049,15 @@ internal static string UseCompatibleCmdletsName {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to The command &apos;{0}&apos; is not available by default in PowerShell version &apos;{1}&apos; on platform &apos;{2}&apos;.
+        /// </summary>
+        internal static string UseCompatibleCommandsCommandError {
+            get {
+                return ResourceManager.GetString("UseCompatibleCommandsCommandError", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to Use compatible commands.
         /// </summary>
@@ -2068,20 +2077,20 @@ internal static string UseCompatibleCommandsDescription {
         }
         
         /// <summary>
-        ///   Looks up a localized string similar to The command &apos;{0}&apos; is not available by default in PowerShell version &apos;{1}&apos; on platform &apos;{2}&apos;.
+        ///   Looks up a localized string similar to UseCompatibleCommands.
         /// </summary>
-        internal static string UseCompatibleCommandsError {
+        internal static string UseCompatibleCommandsName {
             get {
-                return ResourceManager.GetString("UseCompatibleCommandsError", resourceCulture);
+                return ResourceManager.GetString("UseCompatibleCommandsName", resourceCulture);
             }
         }
         
         /// <summary>
-        ///   Looks up a localized string similar to UseCompatibleCommands.
+        ///   Looks up a localized string similar to The parameter &apos;{0}&apos; is not available for command &apos;{1}&apos; by default in PowerShell version &apos;{2}&apos; on platform &apos;{3}&apos;.
         /// </summary>
-        internal static string UseCompatibleCommandsName {
+        internal static string UseCompatibleCommandsParameterError {
             get {
-                return ResourceManager.GetString("UseCompatibleCommandsName", resourceCulture);
+                return ResourceManager.GetString("UseCompatibleCommandsParameterError", resourceCulture);
             }
         }
         
@@ -2148,6 +2157,24 @@ internal static string UseCompatibleTypesDescription {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to The member &apos;{0}&apos; is not available on type &apos;{1}&apos; by default in PowerShell version &apos;{2}&apos; on platform &apos;{3}&apos;.
+        /// </summary>
+        internal static string UseCompatibleTypesMemberError {
+            get {
+                return ResourceManager.GetString("UseCompatibleTypesMemberError", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to The method &apos;{0}&apos; is not available on type &apos;{1}&apos; by default in PowerShell version &apos;{2}&apos; on platform &apos;{3}&apos;.
+        /// </summary>
+        internal static string UseCompatibleTypesMethodError {
+            get {
+                return ResourceManager.GetString("UseCompatibleTypesMethodError", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to UseCompatibleTypes.
         /// </summary>
diff --git a/Rules/Strings.resx b/Rules/Strings.resx
index 8ea17b984..48861402c 100644
--- a/Rules/Strings.resx
+++ b/Rules/Strings.resx
@@ -819,9 +819,12 @@
   <data name="UseCompatibleCommandsDescription" xml:space="preserve">
     <value>Use commands compatible with the given PowerShell version and operating system</value>
   </data>
-  <data name="UseCompatibleCommandsError" xml:space="preserve">
+  <data name="UseCompatibleCommandsCommandError" xml:space="preserve">
     <value>The command '{0}' is not available by default in PowerShell version '{1}' on platform '{2}'</value>
   </data>
+  <data name="UseCompatibleCommandsParameterError" xml:space="preserve">
+    <value>The parameter '{0}' is not available for command '{1}' by default in PowerShell version '{2}' on platform '{3}'</value>
+  </data>
   <data name="UseCompatibleTypesName" xml:space="preserve">
     <value>UseCompatibleTypes</value>
   </data>
@@ -834,6 +837,12 @@
   <data name="UseCompatibleTypesTypeError" xml:space="preserve">
     <value>The type '{0}' is not available by default in PowerShell version '{1}' on platform '{2}'</value>
   </data>
+  <data name="UseCompatibleTypesMethodError" xml:space="preserve">
+    <value>The method '{0}' is not available on type '{1}' by default in PowerShell version '{2}' on platform '{3}'</value>
+  </data>
+  <data name="UseCompatibleTypesMemberError" xml:space="preserve">
+    <value>The member '{0}' is not available on type '{1}' by default in PowerShell version '{2}' on platform '{3}'</value>
+  </data>
   <data name="UseCompatibleSyntaxName" xml:space="preserve">
     <value>UseCompatibleSyntax</value>
   </data>