Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Clarify "Script, Environment and Global Variable Names Include Scope" Rule #250

Closed
PlagueHO opened this issue Mar 1, 2017 · 3 comments
Closed

Comments

@PlagueHO
Copy link
Contributor

PlagueHO commented Mar 1, 2017

@johlju and I have been having a discussion around the meaning of this rule.

Could we clarify this? Does it mean we need to add scope to every variable? Or just the variables that are defined as $script, $env or $global?

E.g. Should $local scope be specified for every variable.

I think we should only be specifying scope if a variable needs to be anything but $local

@mbreakey3
Copy link
Member

Yes. Just $script, $env, and $global variables should be specified. $local does not need to be added.

@johlju
Copy link
Contributor

johlju commented Apr 17, 2018

We got this clarified, so I suggest we close this issue.

@PlagueHO
Copy link
Contributor Author

Yep, closing it! Thanks @johlju

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants