Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Selective generic text file testing based upon file type #307

Open
stevehose opened this issue Jan 16, 2019 · 2 comments
Open

Selective generic text file testing based upon file type #307

stevehose opened this issue Jan 16, 2019 · 2 comments
Labels
discussion The issue is a discussion. enhancement The issue is an enhancement request.

Comments

@stevehose
Copy link

This request is for improving testing. Currently, integration testing analyzes text files ('.gitignore', '.gitattributes', '.ps1', '.psm1', '.psd1', '.json', '.xml', '.cmd', '.mof', '.md', '.js', '.yml') with several tests such as looking for empty files, Unicode encoding, content with tab characters, and files that do not end with a newline character. A better approach is to select which tests are appropriate for each file type. For example, a .xml file doesn't have to end with a newline and it is irrelevant if it contains a tab character, but it shouldn't be an empty file or be Unicode-encoded. No files should be empty (that I'm aware of).

@stevehose stevehose changed the title Selective generic testing based upon file type Selective generic text file testing based upon file type Jan 16, 2019
@PlagueHO PlagueHO added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jan 18, 2019
@PlagueHO
Copy link
Contributor

Thank you for raising this @stevehose. This certainly could be done. I'd recommend if such changes were made we would use a data driven approach (e.g. a PSD1 file defining each file type and the test types that should apply). But we should leave this up for community discussion.

@PlagueHO PlagueHO added discussion The issue is a discussion. and removed help wanted The issue is up for grabs for anyone in the community. labels Jan 18, 2019
@stevehose
Copy link
Author

Awesome! Thanks for the reply. I'll start working on a fork and proposal and we can review it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
discussion The issue is a discussion. enhancement The issue is an enhancement request.
Projects
None yet
Development

No branches or pull requests

2 participants