Renamed field that specifies adapted type #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmenaga
changed the title
anmenaga
force-pushed
the
rename_type_prop
branch
from
8c95c84
to
64176ec
Compare
This is already greatly covered by existing tests. Every non-List PSAdapter (and other adapters) operation uses this code path. |
But we don't have an explicit test to verify the behavior otherwise it would have failed before this change |
anmenaga
force-pushed
the
rename_type_prop
branch
from
64176ec
to
55b152f
Compare
|
Added tests and a test adapter that verifies the renamed field. |
SteveL-MSFT
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Previously, when an adapter process is invoked (for the
dsc resource ...command) the actual resource type name is added to the input JSON bag as a specialtypefield.This results in collisions if resource has an actual
typeproperty. (e.g.PSDesiredStateConfiguration/Fileresource)This PR renames the special field in the json to
adapted_dsc_typewhich is less likely to cause collisions.