Fix indicatif prog bar #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
requested changes
Mar 8, 2024
SteveL-MSFT
requested changes
Mar 8, 2024
dsc_lib/src/configure/mod.rs
Outdated
| @@ -246,7 +247,8 @@ impl Configurator { | |||
| result.results.push(resource_result); | |||
| } | |||
|
|
|||
| pb.finish_with_message("Get configuration completed"); | |||
| mem::drop(pb_span_enter); | |||
There was a problem hiding this comment.
is this needed explicitly? I would expect both to be dropped when going out of scope
There was a problem hiding this comment.
it's needed within the config functions but I removed it from resource list
SteveL-MSFT
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
warn_spanfor progress bars since that is the default tracing level and can be turned off by specifyingerrortrace leveldonemessages are removedPR Context
dsc resource listdemo:demo-list-2.mp4
dsc config getdemo:demo-get-2.mp4