Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed WinPSAdapter operations for Binary resources #480

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

anmenaga
Copy link
Collaborator

@anmenaga anmenaga commented Jul 2, 2024

PR Summary

Fix #445

  1. Fixing a typo in WinPSAdapter which was causing it to always run Get operation regardless of what operation was requested by the dsc.
  2. renamed several local variables in WinPSAdapter to more accurately describe their use.

Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

@anmenaga
Copy link
Collaborator Author

anmenaga commented Jul 3, 2024

Added test.

@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue Jul 8, 2024
Merged via the queue into PowerShell:main with commit 1b7ea41 Jul 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows PowerShell not running Set operation
2 participants