Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery optimizations #173

Closed
SteveL-MSFT opened this issue Aug 29, 2023 · 2 comments · Fixed by #240
Closed

Discovery optimizations #173

SteveL-MSFT opened this issue Aug 29, 2023 · 2 comments · Fixed by #240
Assignees
Labels
Issue-Enhancement The issue is a feature or idea

Comments

@SteveL-MSFT
Copy link
Member

Summary of the new feature / enhancement

Current design always performs a complete discovery, this will need to be changed with the following proposed optimizations:

  1. When using dsc resource get -r <resourceName> if the is found, we don't continue with discovery.
  2. If a config is provided, if a resource provider isn't used, don't call it to do discovery

Proposed technical implementation details (optional)

No response

@SteveL-MSFT SteveL-MSFT added the Issue-Enhancement The issue is a feature or idea label Aug 29, 2023
@michaeltlombardi
Copy link
Collaborator

A future, but related enhancement - it would be useful to cache resource lookups and reuse the cache (or specifically invalidate it with a command flag). I think caching is likely more useful for providers than for DSC itself, but I can definitely see that as being useful to some degree, especially if you have a lot of resources on a system.

@anmenaga anmenaga self-assigned this Sep 12, 2023
@anmenaga
Copy link
Collaborator

Additional details that will make some scenarios (like when only using native resources) way faster:

  1. resources search is used one dir at a time in %PATH%; if at some point all required resources are found -> abort the search and start the actual operation
  2. In every directory from step1 first search native resources, and, if required resource not found, search resource providers in that directory.

@anmenaga anmenaga moved this to In Progress in DSCv3 alpha.4 Sep 29, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in DSCv3 alpha.4 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement The issue is a feature or idea
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants