Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Module Name to ComputerManagementDsc #119

Closed
PlagueHO opened this issue Dec 8, 2017 · 4 comments · Fixed by #151
Closed

Convert Module Name to ComputerManagementDsc #119

PlagueHO opened this issue Dec 8, 2017 · 4 comments · Fixed by #151
Assignees
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.

Comments

@PlagueHO
Copy link
Member

PlagueHO commented Dec 8, 2017

As per recent DSC Resource Naming guidelines changes:
https://github.com/PowerShell/DscResources/blob/master/Naming.md

This should also include merging of SystemLocaleDsc and TimezoneDsc

@PlagueHO PlagueHO added this to the ComputerManagementDsc milestone Dec 8, 2017
@PlagueHO PlagueHO added help wanted The issue is up for grabs for anyone in the community. enhancement The issue is an enhancement request. breaking change When used on an issue, the issue has been determined to be a breaking change. labels Dec 8, 2017
@PlagueHO PlagueHO added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jan 16, 2018
@timhaintz
Copy link
Contributor

@PlagueHO if we get StorageDsc sorted out, happy to do this one next.
Looks to be a couple of extra steps with incorporating SystemLocaleDsc, TimezoneDsc and LanguageDsc Modules. Happy to help out though.
Thanks, Tim.

@PlagueHO
Copy link
Member Author

Hi @timhaintz - would definitely appreciate the help! But I've actually already done this one - I'm just waiting till after the next resource kit release to merge it (as I wanted some bug fixes to go out to xComputerManagement before we rename it).

But I've got other ones that haven't been done if you want to have at it 😁 xCertificate and xDFS.

I'm working on xNetworking rename, but I want to complete the conversion to HQRM on that one before renaming (which takes quite a bit of time).

Your help is really great and very much appreciated! 🏆

@timhaintz
Copy link
Contributor

Cool, no worries. Are xCertificate and xDFS good to go from an HQRM perspective? Will have a go at them this week. 👍 . Thanks.

@PlagueHO
Copy link
Member Author

Yep! xDFS and xCertificate are both HQRM already (the only one that I maintain that isn't HQRM is xNetworking because it has so many resources in it).

@PlagueHO PlagueHO self-assigned this Feb 8, 2018
PlagueHO added a commit that referenced this issue Apr 27, 2018
BREAKING CHANGE: Renamed ComputerManagement to ComputerManagementDsc - Fixes #119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.
Projects
None yet
2 participants