Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xActiveDirectory: All localized strings should have a string ID suffix #419

Closed
johlju opened this issue Jul 8, 2019 · 0 comments · Fixed by #428
Closed

xActiveDirectory: All localized strings should have a string ID suffix #419

johlju opened this issue Jul 8, 2019 · 0 comments · Fixed by #428
Assignees
@johlju
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Jul 8, 2019

There are resources that currently does not have a localized string ID suffix. We should add this ID to all localized strings.

See style guideline here: https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#localization-string-id-suffix
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Jul 8, 2019
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jul 11, 2019
@johlju johlju self-assigned this Jul 11, 2019
@johlju johlju mentioned this issue Jul 11, 2019
Merged
9 tasks
johlju added a commit that referenced this issue Jul 12, 2019
@johlju
xActiveDirectory: Fix various documentation issues (#428)
df33929 
- Changes to xActiveDirectory
  - Style guideline cleanup.
      - All localized strings in the resources now has a string ID suffix (issue #419).
      - All schema properties description now ends with full stop (.) (issue #420).
      - Updated all types in the resources schema to use PascalCase.
    - Updated all resource read-only parameters to start the description
      with 'Returns...' so it is more clear that the property cannot be
      assigned a value.
    - The default value on resource parameters are now reflected in the parameter
      descriptions in the schema.mof (so that Wiki will be updated) (issue #426).
- Changes to xADServicePrincipalName
  - Minor change to the unit tests that did not correct assert the localized
    string when an account is not found.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johlju johlju

Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xActiveDirectory: Fix various documentation issues johlju/ActiveDirectoryDsc
1 participant
@johlju