Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WaitForADDomain: Should be able to use PsDscRunAsCredential #367

Closed
johlju opened this issue Jun 12, 2019 · 0 comments · Fixed by #455
Closed

WaitForADDomain: Should be able to use PsDscRunAsCredential #367

johlju opened this issue Jun 12, 2019 · 0 comments · Fixed by #455
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Jun 12, 2019

Currently it is not possible to run the resource using the built-in credentials PsDscRunAsCredential.

When using the PsDscRunAsCredential the username is stored in $PsDscContext.RunAsUser and can be used to evaluate ($null -ne $PsDscContext.RunAsUser) if the resource is running using a credential passas in PsDscRunAsCredential, or output the username in a verbose message.
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jun 12, 2019
@johlju johlju changed the title xWaitForADDomain: Should be able to use PsDscRunAsCredential WaitForADDomain: Should be able to use PsDscRunAsCredential Jul 28, 2019
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 30, 2019
@johlju
Changes to WaitForADDomain
dc13ddd 
- BREAKING CHANGE: Refactored the resource to handle timeout better and
  more correctly wait for a specific amount, and at the same time make
  the resource more intuitive to use. This change has replaced parameters
  in the resource (issue dsccommunity#343).
- Now the resource can use built-in `PsDscRunAsCredential` instead of
  specifying the `Credential` parameter (issue dsccommunity#367).
- New parameter `SiteName` can be used to wait for a domain controller
  in a specific site in the domain.
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jul 30, 2019
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Jul 30, 2019
@johlju
Changes to WaitForADDomain
02be28d 
- BREAKING CHANGE: Refactored the resource to handle timeout better and
  more correctly wait for a specific amount, and at the same time make
  the resource more intuitive to use. This change has replaced parameters
  in the resource (issue dsccommunity#343).
- Now the resource can use built-in `PsDscRunAsCredential` instead of
  specifying the `Credential` parameter (issue dsccommunity#367).
- New parameter `SiteName` can be used to wait for a domain controller
  in a specific site in the domain.
@johlju johlju mentioned this issue Aug 1, 2019
Merged
9 tasks
johlju added a commit that referenced this issue Aug 2, 2019
@johlju
BREAKING CHANGE: WaitForADDomain: Refactored the resource to handle t…
3efea91 
…imeout better (#455)

- Changes to ActiveDirectoryDsc
  - The helper function `Find-DomainController` is exported in the module
    manifest. When running `Import-Module -Name ActiveDirectoryDsc` the
    module will also import the nested module ActiveDirectoryDsc.Common.
    It is exported so that the resource WaitForADDomain can reuse code
    when running a background job to search for a domain controller.
  - Changes to ActiveDirectoryDsc.Common:
    - Added function `Find-DomainController`.
    - Added function `Get-CurrentUser` (moved from the resource ADKDSKey).
- Changes to WaitForADDomain
  - BREAKING CHANGE: Refactored the resource to handle timeout better and
    more correctly wait for a specific amount of time, and at the same time
    make the resource more intuitive to use. This change has replaced
    parameters in the resource ([issue #343](#343)).
  - Now the resource can use built-in `PsDscRunAsCredential` instead of
    specifying the `Credential` parameter ([issue #367](#367)).
  - New parameter `SiteName` can be used to wait for a domain controller
    in a specific site in the domain.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
1 participant
@johlju