Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADReplicationSiteLink: Integration tests is missing for this resource #356

Closed
johlju opened this issue Jun 7, 2019 · 4 comments · Fixed by #509
Closed

ADReplicationSiteLink: Integration tests is missing for this resource #356

johlju opened this issue Jun 7, 2019 · 4 comments · Fixed by #509
Labels
tests The issue or pull request is about tests only.

Comments

@johlju
Copy link
Member

johlju commented Jun 7, 2019

We should add integration tests for this resource.
@johlju johlju added help wanted The issue is up for grabs for anyone in the community. tests The issue or pull request is about tests only. labels Jun 7, 2019
@johlju johlju changed the title xADReplicationSiteLink: Integration tests is missing for this resource ADReplicationSiteLink: Integration tests is missing for this resource Jul 28, 2019
@1800Zeta
Copy link
Contributor

Hi @johlju

To do the integration tests for the Site Links, existing sites will need to be created beforehand. Should I put the New-ADReplicationSite commands in the Try of the integration.tests.ps1 file just after the configFile = join-path or should I put them elsewhere? I will add a remove-ADReplicationSite at the end of the tests.

@johlju
Copy link
Member Author

johlju commented Sep 18, 2019 •
edited
Loading

I usually make a prerequisites integration test that creates dependencies using DSC. That integration test only runs the Start test and I skip Get-test and Test-test.

If that is not possible, there are no DSC resources to make why you need, then add the necessary code in a BeforeAll-block in the Describe-block.

@johlju
Copy link
Member Author

johlju commented Sep 18, 2019

See example here https://github.com/PowerShell/ActiveDirectoryDsc/blob/ae42a2cb0eecb4b5f4f2abcb74edd5de58bb20a6/Tests/Integration/MSFT_ADObjectEnabledState.config.ps1#L32

@1800Zeta
Copy link
Contributor

Perfect thank you very much. Will do that 👍

@1800Zeta 1800Zeta mentioned this issue Sep 23, 2019
Merged
10 tasks
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Oct 9, 2019
johlju pushed a commit that referenced this issue Oct 15, 2019
@1800Zeta @johlju
ADReplicationSiteLink: Add Integration tests, add setting 'options' (#…
c3c93ba 
…509)

- Changes to ADReplicationSiteLink
  - Added Integration testing (issue #356).
  - Added ability to set 'Options' such as Change Notification Replication (issue #504).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests The issue or pull request is about tests only.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ADReplicationSiteLink: Add Integration tests, add setting 'options'
2 participants
@johlju @1800Zeta