Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADUser: Remove unused non-mandatory parameters from the Get-TargetResource function #293

Closed
SSvilen opened this issue May 23, 2019 · 0 comments · Fixed by #487
Closed

ADUser: Remove unused non-mandatory parameters from the Get-TargetResource function #293

SSvilen opened this issue May 23, 2019 · 0 comments · Fixed by #487
Assignees
@SSvilen
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@SSvilen
Copy link
Contributor

SSvilen commented May 23, 2019

According to DSC Resource Style Guidelines & Best Practices there should be only mandatory parameters in the Get-TargetResource function.
The unused non-mandatory parameters should be removed.
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels May 25, 2019
@johlju johlju changed the title xADUser: Remove unused non-mandatory parameters from the Get-TargetResource function ADUser: Remove unused non-mandatory parameters from the Get-TargetResource function Jul 28, 2019
@SSvilen SSvilen mentioned this issue Aug 18, 2019
Merged
10 tasks
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Aug 18, 2019
johlju pushed a commit that referenced this issue Aug 24, 2019
@SSvilen @johlju
ADUser: Remove unused non-mandatory parameters from the Get-TargetRes…
1bd8745 
…ource (#487)

- Changes to ADUser
  - Remove unused non-mandatory parameters from the Get-TargetResource (issue #293).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SSvilen SSvilen

Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
2 participants
@johlju @SSvilen