Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/gaexport #11

Closed
Crayder opened this issue Aug 3, 2015 · 9 comments
Closed

/gaexport #11

Crayder opened this issue Aug 3, 2015 · 9 comments
Milestone

Comments

@Crayder
Copy link
Collaborator

Crayder commented Aug 3, 2015

Complete the /gaexport command.

@Crayder Crayder added this to the Do before 1.9 milestone Aug 3, 2015
@Crayder
Copy link
Collaborator Author

Crayder commented Nov 3, 2015

@Pottus What exactly is wrong with this? You have it commented out, and I haven't tried commenting it yet.

@Pottus
Copy link
Owner

Pottus commented Nov 4, 2015

It was never completed the intention is to export a group of objects attached to a golf ball located at the group centre. I can't remember what is wrong with it but I didn't finish it and never got back around to completing it in fact I just looked at it and it appears to be completed a lot more than I thought.

@Crayder
Copy link
Collaborator Author

Crayder commented Nov 4, 2015

Oh, I edited it a while back, I didn't have the commit in it's own commit though.

85a83e3

I forgot where I was going with it. It looks good so I guess I'll just have to test it.

@Crayder
Copy link
Collaborator Author

Crayder commented Nov 4, 2015

Ok, so the current code (from the commit mentioned above) crashes after entering the parent object. It's the first fwrite line after fopen so it's a file crash. I tried using ftouch and io_append to get past it, neither worked. The file is never created.

@Pottus
Copy link
Owner

Pottus commented Nov 4, 2015

Maybe the folder does not exist.

@Pottus
Copy link
Owner

Pottus commented Nov 4, 2015

One more thing this line here.
format(templine,sizeof(templine),"centobjid = CreateObject(%i,%.3f,%.3f,%.3f,%.3f,%.3f,%.3f,%.3f);\r\n",ObjectData[centerindex][oModel],ObjectData[centerindex][oX],ObjectData[centerindex][oY],ObjectData[centerindex][oZ],ObjectData[centerindex][oRX],ObjectData[centerindex][oRY],ObjectData[centerindex][oRZ],drawdist);

The center object should be a golf ball with it's material colour set so that it is invisible. That means a centerindex shouldn't be used get the group center instead.

@Crayder
Copy link
Collaborator Author

Crayder commented Nov 4, 2015

  • Maybe the folder does not exist.

It does, I even have it created here in this repo. It contains a blank text file.

  • The center object should be a golf ball with it's material colour set so that it is invisible. That means a centerindex shouldn't be used get the group center instead.

I like the idea of choosing an object to be the parent instead. There are a few good reasons. One great one would be considering the fact that the physical center is not always the best center of rotation. For example, what if I made my own door or something and the parent object should be the hinge? A golf ball in the center wouldn't work for that scenario. I could easily default it to a golf ball at the center though, that would make sense with a note [like in the draw distance dialog] saying that if nothing is entered it will default to the center. Your opinion on that?

@Crayder
Copy link
Collaborator Author

Crayder commented Nov 19, 2015

Okay so this is done and implemented for public use. But it still doesn't create the file, no matter what I try to do. The folder is perfectly valid and all other file operations work perfectly fine. I don't get it!

@Crayder
Copy link
Collaborator Author

Crayder commented Nov 22, 2015

I'm going to go ahead and close this issue, it's technically working but without the actual new file.

@Pottus if you could look into the file creating that'd be great, I really don't see what I could possibly be doing wrong. It's probably something minor that I'm just not noticing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants