Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to dashboard button in funnels #4986

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Add to dashboard button in funnels #4986

merged 1 commit into from
Jul 5, 2021

Conversation

paolodamico
Copy link
Contributor

Changes

Brings back "Add to dashboard" button on funnels view. Looks like it may have been accidentally removed when rebasing/merging #4893.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@timgl timgl temporarily deployed to posthog-pr-4986 July 5, 2021 09:05 Inactive
@macobo
Copy link
Contributor

macobo commented Jul 5, 2021

This closes #4979 (though the second half, why there are two save operations, remains)

@paolodamico paolodamico mentioned this pull request Jul 5, 2021
Closed
@paolodamico paolodamico merged commit 1331ab1 into master Jul 5, 2021
@paolodamico paolodamico deleted the fix-funnel-save-to-dashboard branch July 5, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macobo macobo macobo approved these changes

@samwinslow samwinslow Awaiting requested review from samwinslow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paolodamico @macobo @timgl