-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legend key in chart #4594
Comments
I played with a few different options for this. (I built them in my newer experimental UI, but they port pretty easily to what we have today.) 1. Side legendWe only need a legend if there is >1 thing being graphed. When there is, we can reduce the width of the graph to fit the legend. One benefit here is that there is a nice, consistent alignment, which wouldn't happen if the labels were listed horizontally above or below (like in the next two options). 2. Legend belowThe most standard option, the labels grow from the middle. Middle alignment could, of course, get weird with long labels 3. Legend aboveI actually sort of like this version because it puts the labels from and center. In this case, we'd just allow enough whitespace above where the graph actually starts. It's designed to look like it's just dropped in the available space, but the space would grow as needed. Open questions
|
My thoughts:
POV? |
Yep, agreed @paolodamico. Top is best, lines were really more intended for this visual refresh, so adapting them to what we have today is perfect. I added a little more info in these, spaced them evenly, and truncated the middle one to get a sense for what it would look like. Do you think you have enough to run with it within the context of the current design? |
This is great, thanks @corywatilo! I'll tweak the UI a bit (for the current version) to get your thoughts before we can mark this as ready to implement. |
I was working on some chart patterns and put in a few rounds on legends. One thing to think about is scale. In some cases, visualizations might have a really large number of metrics. A conditionally displayed legend might be a good solution for a consistent means of translating a chart. Also worth noting that the tooltip for some charts is mostly a repeat of the legend information, so we have multiple components contributing to this solution. |
Yes!! Really love this legend key, let's make it happen! Will tag this as a good first issue as I think with the design (and the already existing tooltip logic) it can be fairly straightforward to pick up. |
@clarkus @mariusandra what are your thoughts on having this on insights? I'm not convinced is solving a real problem, as we've haven't had more feedback from users on this. |
This would definitely help people who are making screenshots of insights, and should probably be tracked in the "nail analytics" doc, but we definitely have higher priorities to tackle first. |
It depends. I can see it adding value in some scenarios, while being completely redundant in others. I think focusing on other priorities first is a good call. |
Legend key is live! |
Is your feature request related to a problem?
Currently we show the legend table describing each graph series at the bottom of the graph. This is not ideal because a) you have to know it's there, b) you have to scroll which makes visualization more difficult and c) doesn't work well for screenshots.
Describe the solution you'd like
I'd like us to introduce a legend key within the graph. See one example below.
Describe alternatives you've considered
Keep only the legend table at the bottom.
Additional context
Related to #4492.
Thank you for your feature request – we love each and every one!
The text was updated successfully, but these errors were encountered: