-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug with retention cohorts & filtering #2654
Comments
This is a really interesting catch. I think technically speaking this is possible because what's happening is that when you do first time retention it's trying to calculate the first time a user performed that event with those filters across all time. So the extra users in the graph with more filters happens because those users might actually exist already and were grouped into previous cohorts in graph 1, but then their first event with the new filter is in a later cohort so there ends up being more in those later cohorts. lmk if this makes sense! Nontechnically speaking, this is very counter intuitive and somehow we need to clarify what we're going for here |
@paolodamico bump |
Right, the technical part makes total sense. I think we can do a few things to clarify the UX:
As for the goal of this query, I think that's still a bit tricky. Basically what I wanted to answer is if users who have that feature flag active (or inactive) retain better; which means I was expecting to have the same retention table, but adding a filter on top for users with the feature flag. If the cohorts are created based on when the user first performed the action while having the feature flag active, then there's the noise of when the feature flag became active for that user, and not a very accurate retention reading. Thoughts? |
This issue hasn't seen activity in two years! If you want to keep it open, post a comment or remove the |
This issue was closed due to lack of activity. Feel free to reopen if it's still relevant. |
Bug description & expected behavior
I stumbled across this bug, when doing retention analysis. Graph 1 is the same as Graph 2 except that Graph 2 introduces an extra filter. However, as you can see from the screenshots below, for the weeks of Oct 24 & Oct 31, the cohort sizes are larger for Graph 2, which doesn't make sense because Graph 2 adds a constraint. At most, Graph 2's cohort sizes should equal Graph 1's.
Graph 1.
Graph 2.
How to reproduce
Environment
Cloud (Clickhouse).
Additional context
Thank you for your bug report – we love squashing them!
The text was updated successfully, but these errors were encountered: