Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with retention cohorts & filtering #2654

Closed
paolodamico opened this issue Dec 3, 2020 · 5 comments
Closed

Bug with retention cohorts & filtering #2654

paolodamico opened this issue Dec 3, 2020 · 5 comments
Assignees
Labels
bug Something isn't working right feature/trends Feature Tag: Trends stale

Comments

@paolodamico
Copy link
Contributor

Bug description & expected behavior

I stumbled across this bug, when doing retention analysis. Graph 1 is the same as Graph 2 except that Graph 2 introduces an extra filter. However, as you can see from the screenshots below, for the weeks of Oct 24 & Oct 31, the cohort sizes are larger for Graph 2, which doesn't make sense because Graph 2 adds a constraint. At most, Graph 2's cohort sizes should equal Graph 1's.

Graph 1.

Graph 2.

How to reproduce

  1. Open the graphs referenced above.

Environment

Cloud (Clickhouse).

Additional context

Thank you for your bug report – we love squashing them!

@paolodamico paolodamico added the bug Something isn't working right label Dec 3, 2020
@paolodamico paolodamico mentioned this issue Dec 3, 2020
14 tasks
@macobo macobo added the feature/trends Feature Tag: Trends label Dec 3, 2020
@EDsCODE
Copy link
Member

EDsCODE commented Dec 3, 2020

This is a really interesting catch.

I think technically speaking this is possible because what's happening is that when you do first time retention it's trying to calculate the first time a user performed that event with those filters across all time. So the extra users in the graph with more filters happens because those users might actually exist already and were grouped into previous cohorts in graph 1, but then their first event with the new filter is in a later cohort so there ends up being more in those later cohorts. lmk if this makes sense!

Nontechnically speaking, this is very counter intuitive and somehow we need to clarify what we're going for here

@EDsCODE EDsCODE self-assigned this Dec 8, 2020
@EDsCODE
Copy link
Member

EDsCODE commented Dec 8, 2020

@paolodamico bump

@paolodamico
Copy link
Contributor Author

Right, the technical part makes total sense. I think we can do a few things to clarify the UX:

  • On the RHS panel (where you select first time retention & the filters) we could add a legend that says something like "Filtering for users that did X action with the selected filters, for the first time".
  • When hovering on the cohort size we can show a tooltip with the same information (maybe emphasize the filtering part, or even better would be listing the filters in a human-friendly way).
  • When opening the persons modal (after clicking a cohort), show the same information in the header of the table.

As for the goal of this query, I think that's still a bit tricky. Basically what I wanted to answer is if users who have that feature flag active (or inactive) retain better; which means I was expecting to have the same retention table, but adding a filter on top for users with the feature flag. If the cohorts are created based on when the user first performed the action while having the feature flag active, then there's the noise of when the feature flag became active for that user, and not a very accurate retention reading. Thoughts?

@posthog-bot
Copy link
Contributor

This issue hasn't seen activity in two years! If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in two weeks.

@posthog-bot
Copy link
Contributor

This issue was closed due to lack of activity. Feel free to reopen if it's still relevant.

@posthog-bot posthog-bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right feature/trends Feature Tag: Trends stale
Projects
None yet
Development

No branches or pull requests

4 participants