Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calculate button to Retention #1643

Closed
yakkomajuri opened this issue Sep 10, 2020 · 1 comment
Closed

Add calculate button to Retention #1643

yakkomajuri opened this issue Sep 10, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@yakkomajuri
Copy link
Contributor

Is your feature request related to a problem?

Please describe.

Add a button to calculate retention instead of doing it automatically on a filter update. This will help prevent race conditions with retention queries.

Opening this up because the fix is a little longer than I anticipated so leaving this here as a note to myself to pick it up later when I actually have time or for someone else to pick it up.

Describe the solution you'd like

Funnels-like 'Calculate' button.

Describe alternatives you've considered

Leave as is

Additional context

Thank you for your feature request – we love each and every one!

@yakkomajuri yakkomajuri added the enhancement New feature or request label Sep 10, 2020
@paolodamico paolodamico mentioned this issue Nov 5, 2020
14 tasks
@EDsCODE
Copy link
Member

EDsCODE commented Nov 16, 2020

I fixed the race condition with a breakpoint. Feel free to open it up again if you think calculate would be better overall or if it's ok the way it is now!

@EDsCODE EDsCODE closed this as completed Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants