Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO #2

Closed
ghost opened this issue Apr 10, 2020 · 2 comments
Closed

TODO #2

ghost opened this issue Apr 10, 2020 · 2 comments

Comments

@ghost
Copy link

ghost commented Apr 10, 2020

1, should handle 'host' (https://www.test.com) and 'use_ssl' => true, it becomes https://https://www.test.com
2, LibCurl the batch api endpoint is 'capture' rather than 'batch'
3, the endless loop when http code is 0
@mariusandra
Copy link
Collaborator

Hi @WPPD ! Thank you for reporting these issues!

  1. Done. Now if you specify host with either http:// or https://, it'll automatically set the ssl parameter.
  2. I couldn't replicate this. It looks like /batch/ to me...?
  3. The code 0 will now be treated as a regular error. No more endless loop!

@ghost
Copy link
Author

ghost commented Apr 14, 2020

oh I was going to squeeze some time to contribute.... 2 I will test it again

@ghost ghost closed this as completed Apr 18, 2020
@wesleymartincc wesleymartincc mentioned this issue Oct 28, 2022
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mariusandra