Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse Chrome instead of Android as browser #1575

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Dec 2, 2024

Changes

Based on some Googling it seems like the latter value in this user agent (Chrome/28.0.1500.94 ) is actually the browser.

Maybe we don't want to make this change because it will affect peoples existing browser attribution but I think it's totally reasonable to ship a fix forward here

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Dec 3, 2024 11:09am

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

Size Change: -21 B (0%)

Total Size: 3.18 MB

Filename Size Change
dist/array.full.es5.js 258 kB -2 B (0%)
dist/array.full.js 361 kB -2 B (0%)
dist/array.full.no-external.js 360 kB -2 B (0%)
dist/array.js 175 kB -2 B (0%)
dist/array.no-external.js 174 kB -2 B (0%)
dist/customizations.full.js 12.5 kB -1 B (-0.01%)
dist/main.js 176 kB -2 B (0%)
dist/module.full.js 361 kB -2 B (0%)
dist/module.full.no-external.js 360 kB -2 B (0%)
dist/module.js 175 kB -2 B (0%)
dist/module.no-external.js 174 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 206 kB
dist/dead-clicks-autocapture.js 14.3 kB
dist/exception-autocapture.js 9.37 kB
dist/external-scripts-loader.js 2.29 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.2 kB
dist/tracing-headers.js 1.75 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@daibhin daibhin merged commit 4d705fd into main Dec 3, 2024
13 checks passed
@daibhin daibhin deleted the dn-fix/parse-chrome-browser branch December 3, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants