Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hog site functions #1546

Merged
merged 6 commits into from
Nov 27, 2024
Merged

feat: hog site functions #1546

merged 6 commits into from
Nov 27, 2024

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Nov 22, 2024

Changes

Companion for PostHog/posthog#26169

  • Always send $elements_chain as a property (there's just 1 client who's still receiving $elements)
  • Send events to the function only once an app has loaded. This also sends events that would've been missed while the app is loading.
  • Works with existing site apps
  • Works with new site functions/destinations/etc

TODO, can be in followup PRs:

  • Consent opt in/out
  • Test CSS selectors and elements_chain_href type fields

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Nov 26, 2024 11:27am

Copy link

github-actions bot commented Nov 22, 2024

Size Change: +19.7 kB (+0.63%)

Total Size: 3.16 MB

Filename Size Change
dist/all-external-dependencies.js 206 kB +3 B (0%)
dist/array.full.es5.js 257 kB +2.16 kB (+0.85%)
dist/array.full.js 360 kB +1.95 kB (+0.55%)
dist/array.full.no-external.js 359 kB +1.95 kB (+0.55%)
dist/array.js 174 kB +1.95 kB (+1.13%)
dist/array.no-external.js 173 kB +1.95 kB (+1.14%)
dist/dead-clicks-autocapture.js 14.3 kB +3 B (+0.02%)
dist/main.js 175 kB +1.95 kB (+1.13%)
dist/module.full.js 360 kB +1.95 kB (+0.55%)
dist/module.full.no-external.js 359 kB +1.95 kB (+0.55%)
dist/module.js 175 kB +1.96 kB (+1.14%)
dist/module.no-external.js 173 kB +1.95 kB (+1.14%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 9.37 kB
dist/external-scripts-loader.js 2.29 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.2 kB
dist/tracing-headers.js 1.75 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@mariusandra mariusandra added the bump patch Bump patch version when this PR gets merged label Nov 26, 2024
@mariusandra mariusandra merged commit 3644681 into main Nov 27, 2024
17 checks passed
@mariusandra mariusandra deleted the client-side-hog branch November 27, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants