Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: endpoint for is already called inside loadscript #1365

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

pauldambra
Copy link
Member

fixes: #1346

OP correctly identifies that two scripts are passing the fully resolved endpoint into loadScript which then calls endpointFor

Calling endpointFor twice is not (always) safe

Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Aug 19, 2024 8:12am

Copy link

Size Change: -400 B (-0.03%)

Total Size: 1.17 MB

Filename Size Change
dist/array.full.js 333 kB -100 B (-0.03%)
dist/array.js 154 kB -100 B (-0.06%)
dist/main.js 155 kB -100 B (-0.06%)
dist/module.js 154 kB -100 B (-0.06%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 10.4 kB
dist/recorder-v2.js 110 kB
dist/recorder.js 110 kB
dist/surveys-preview.js 59.8 kB
dist/surveys.js 66 kB
dist/tracing-headers.js 8.26 kB
dist/web-vitals.js 5.79 kB

compressed-size-action

@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Aug 19, 2024
@pauldambra pauldambra merged commit f9506be into main Aug 19, 2024
13 checks passed
@pauldambra pauldambra deleted the fix/endpoint-for-endpoint-for branch August 19, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web-vitals extension loads script from incorrect URL
2 participants