Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only add to window when it exists #1362

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Aug 16, 2024

We add error functions to window even when it is undefined... let's copy the other entrypoints and check first

(should) fixes #1349

Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Aug 16, 2024 9:31am

@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Aug 16, 2024
@pauldambra pauldambra requested a review from daibhin August 16, 2024 09:30
Copy link

Size Change: +11 B (0%)

Total Size: 1.17 MB

Filename Size Change
dist/array.full.js 333 kB +6 B (0%)
dist/exception-autocapture.js 10.4 kB +5 B (+0.05%)
ℹ️ View Unchanged
Filename Size
dist/array.js 154 kB
dist/main.js 155 kB
dist/module.js 154 kB
dist/recorder-v2.js 110 kB
dist/recorder.js 110 kB
dist/surveys-preview.js 59.8 kB
dist/surveys.js 66 kB
dist/tracing-headers.js 8.26 kB
dist/web-vitals.js 5.79 kB

compressed-size-action

@pauldambra pauldambra requested a review from a team August 19, 2024 08:05
@pauldambra pauldambra merged commit 62ab9ae into main Aug 19, 2024
14 checks passed
@pauldambra pauldambra deleted the fix/only-when-window branch August 19, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error importing exception-autocapture when disable_external_dependency_loading=true
3 participants