-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: default to gzip compression instead of base64 #1355
Conversation
it's weird that we do our first requests before the decide response with base64 "compression", as 1. we've supported gzip for literally years, so there's basically zero risk of somehow hitting an endpoint that doesn't support it 2. base64 is not compression, it increases the payload size compared to if we did nothing at all 3. rust capture does not support base64
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: 0 B Total Size: 1.17 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be interesting if no tests fail...
5247cb9
to
3e4eb29
Compare
55fd04d
to
659b8d9
Compare
had to fix the mock parsing but looks good now |
Curious: What is the reason we don't use headers/http level compression? |
You can't for requests. (You can't know what the server accepts before sending the request). Thats why you tell the server what you accept with headers like |
Changes
it's weird that we do our first requests before the decide response with base64 "compression", as
Checklist