Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: remove x-posthog-token header #1354

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

frankh
Copy link
Contributor

@frankh frankh commented Aug 13, 2024

Changes

this header causes lots of preflight requests so probably isn't worth it in the end. Not in use yet so no risk to remove (just added in #1347)

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

this causes lots of preflight requests so probably isn't worth it in the end. Not in use yet
@frankh frankh requested a review from benjackwhite August 13, 2024 10:35
Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Aug 13, 2024 10:37am

@frankh frankh changed the title remove x-posthog-token header fix: remove x-posthog-token header Aug 13, 2024
@frankh frankh changed the title fix: remove x-posthog-token header revert: remove x-posthog-token header Aug 13, 2024
Copy link

Size Change: -176 B (-0.02%)

Total Size: 1.17 MB

Filename Size Change
dist/array.full.js 333 kB -44 B (-0.01%)
dist/array.js 154 kB -44 B (-0.03%)
dist/main.js 155 kB -44 B (-0.03%)
dist/module.js 154 kB -44 B (-0.03%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 10.4 kB
dist/recorder-v2.js 110 kB
dist/recorder.js 110 kB
dist/surveys-preview.js 59.8 kB
dist/surveys.js 66 kB
dist/tracing-headers.js 8.26 kB
dist/web-vitals.js 5.79 kB

compressed-size-action

@benjackwhite benjackwhite added the bump patch Bump patch version when this PR gets merged label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants