Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'img' config option does not work #138

Closed
macobo opened this issue Nov 29, 2020 · 5 comments
Closed

'img' config option does not work #138

macobo opened this issue Nov 29, 2020 · 5 comments

Comments

@macobo
Copy link
Contributor

macobo commented Nov 29, 2020

img config option is supposed to create an image tag and do a request to the server based on the url in src attribute.

Sending the request almost works, except it doesn't encode the event name or properties into the url it generates.

@macobo
Copy link
Contributor Author

macobo commented Dec 3, 2020

Actually, sending data via XHR GET would fail for the same reason.

The bug is the same for both - we should put the data into the URL via args: https://github.com/PostHog/posthog-js/blob/master/src/posthog-core.js#L409-L411

Haven't tested if this would work on posthog-side though.

@timgl @mariusandra thoughts on this? Shall we a) fix this or b) drop the unsupported behavior?

@mariusandra
Copy link
Collaborator

I'd drop. We're not really targeting IE8 or whoever anymore. Making a bunch of DOM nodes just to send GET requests seems silly.

@macobo macobo mentioned this issue Dec 11, 2020
@posthog-bot
Copy link
Collaborator

This issue hasn't seen activity in two years! If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in two weeks.

@posthog-bot
Copy link
Collaborator

This issue was closed due to lack of activity. Feel free to reopen if it's still relevant.

@posthog-bot posthog-bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2023
@Twixes Twixes reopened this Apr 20, 2023
@posthog-bot posthog-bot removed the stale label Apr 21, 2023
@pauldambra
Copy link
Member

removed in #651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants